Code review comment for ~williamhsu/plainbox-provider-checkbox/+git/plainbox-provide-checkbox:bug/lp-1884235/exchanged-the-sequence-of-graphics-log-parsing

Revision history for this message
William Hsu (williamhsu) wrote :

@Hugh and Jeremy,
I merged Jeremy's idea into the latest patch. Would it be possible to have your time to review it? Thanks!

# Test result:
## Scenario 1 (NV modeset enabled) ##

u@u:~/WorkSPace/plainbox-provide-checkbox/bin$ ./graphics_driver.py
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: nvidia
Driver Version: 440.64
------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: NVIDIA (10de:1bb1)
Loaded DDX Drivers: nouveau, modesetting, fbdev, vesa
Hybrid Graphics: no

u@u:~/WorkSPace/plainbox-provide-checkbox/bin$ sudo cat /sys/module/nvidia_drm/parameters/modeset
Y

u@u:~/WorkSPace/plainbox-provide-checkbox/bin$ cat /etc/buildstamp
Jenkins Sun, 28 Jun 2020 22:47:15 +0000
pc-sutton-bachman-focal-amd64-X00-20200628-134

## Scenario 2 (NV modeset disabled) ##
u@u-ThinkStation-P920:~/plainbox-provide-checkbox/bin$ ./graphics_driver.py
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: nvidia
Driver Version: 418.56
------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: NVIDIA (10de:1e30)
Loaded DDX Drivers: nouveau, modesetting, fbdev, vesa
Hybrid Graphics: no

u@u-ThinkStation-P920:~/plainbox-provide-checkbox/bin$ sudo cat /sys/module/nvidia_drm/parameters/modeset
N

u@u-ThinkStation-P920:~/plainbox-provide-checkbox/bin$ cat /etc/buildstamp
Jenkins Thu, 23 May 2019 09:08:29 +0000
sutton-mccarthy-bionic-amd64-20190523-122

« Back to merge proposal