Code review comment for ~williamhsu/plainbox-provider-checkbox/+git/plainbox-provide-checkbox:bug/lp-1884235/exchanged-the-sequence-of-graphics-log-parsing

Revision history for this message
William Hsu (williamhsu) wrote :

> so do we have any idea to get AMD info?
> I will suggest to fix AMD one in this MP.

@Hugh, my bad. Thanks to Jeremy's reminder, the Xorg log can help us to find out the AMD driver info. I also ran the script on a AMD test config, it does work. Test result is as follow

u@u-INVALID:/usr/lib/plainbox-provider-checkbox/bin$ lspci | grep -i --color 'vga\|3d\|2d'
61:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Lexa XT [Radeon PRO WX 3200] (rev 10)
u@u-INVALID:/usr/lib/plainbox-provider-checkbox/bin$ ./graphics_driver
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: amdgpu
Driver Version: 19.1.0

------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: AMD (1002:6981)
Loaded DDX Drivers: amdgpu, ati, modesetting, fbdev, vesa
Hybrid Graphics: no

The reason why it failed in the previous test, it's because of the blacklist-amdgpu.conf. It blocked the graphics tests. So, please skip the comment - https://code.launchpad.net/~williamhsu/plainbox-provider-checkbox/+git/plainbox-provide-checkbox/+merge/386796/comments/1020120.

In short, I'm going to implement the Jeremy's idea. Afterwards, we can get together to see if the MR meets the requirements. Thanks!

« Back to merge proposal