Code review comment for ~williamhsu/plainbox-provider-checkbox/+git/plainbox-provide-checkbox:bug/lp-1884235/exchanged-the-sequence-of-graphics-log-parsing

Revision history for this message
William Hsu (williamhsu) wrote :

@ Hugh, according to the information from HWE and SWE, the Xorg logs don't have the necessary AMD driver information. So, we may need to use the other methods to retrieve the AMD driver info. Thanks! :)

@ Everyone, the validations for the patch (Used the Xorg owner to judge the Xorg log location)

### Scenario 1 - Intel Graphic Card (Built-in) ###
(venv_ldtp) whsu@thinkpad-x:~/ws/plainbox-provider-checkbox/bin$ ./graphics_driver.py
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: modesetting
Driver Version: 1.20.5
------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: Intel (8086:0a16)
Loaded DDX Drivers: modesetting, fbdev, vesa
Hybrid Graphics: no

### Scenario 2 - Nvidia Graphic Card, NV modeset = Y ###
u@u-ThinkStation-xxx:/usr/lib/plainbox-provider-checkbox/bin$ sudo cat /sys/module/nvidia_drm/parameters/modeset
Y
u@u-ThinkStation-xxx:/usr/lib/plainbox-provider-checkbox/bin$ ./graphics_driver
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: nvidia
Driver Version: 440.64
------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: NVIDIA (10de:1c31)
Loaded DDX Drivers: nouveau, modesetting, fbdev, vesa
Hybrid Graphics: no

### Scenario 3 - Nvidia Graphic Card, NV modeset = N ###
u@u-ThinkStationP520c:/usr/lib/plainbox-provider-checkbox/bin$ sudo cat /sys/module/nvidia_drm/parameters/modeset
N
u@u-ThinkStationP520c:/usr/lib/plainbox-provider-checkbox/bin$ ./graphics_driver
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: nvidia
Driver Version: 440.64
------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: NVIDIA (10de:1eb1)
Loaded DDX Drivers: nouveau, modesetting, fbdev, vesa
Hybrid Graphics: no

### Scenario 4 - AMD graphic card (A known issue, no AMD driver info on the Xorg log) ###
u@u-ThinkStation-xxx:/usr/lib/plainbox-provider-checkbox/bin$ ./graphics_driver
------------- VIDEO DRIVER INFORMATION -------------
ERROR: No video driver loaded! Possibly in failsafe mode!
------------- HYBRID GRAPHICS CHECK ----------------
Graphics Chipset: AMD (1002:6981)
Loaded DDX Drivers: ati, radeon, modesetting, fbdev, vesa
Hybrid Graphics: no

« Back to merge proposal