Merge lp:~widelands-dev/widelands/weaver_spins_gold into lp:widelands

[GunChleoc]

Gold Spinning Mills are now worked by a Weaver instead of a Carrier.

Some eye candy suggested by https://wl.widelands.org/forum/topic/2869/?page=1#post-20248

It doesn't affect balancing, because weavers don't use a tool.

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 2255. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/236457627.
Appveyor build 2090. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_weaver_spins_gold-2090.

[GunChleoc (gunchleoc)]

This is breaking savegame compatibility and writing good code for that takes more time than I'm willing to invest right now. Postponed to after Build 20.

=== modified file 'data/tribes/buildings/productionsites/atlanteans/gold_spinning_mill/init.lua'
--- data/tribes/buildings/productionsites/atlanteans/gold_spinning_mill/init.lua	2019-05-29 18:29:28 +0000
+++ data/tribes/buildings/productionsites/atlanteans/gold_spinning_mill/init.lua	2019-09-08 18:11:05 +0000
@@ -35,7 +35,7 @@
    },
 
    working_positions = {
-      atlanteans_carrier = 1
+      atlanteans_weaver = 1
    },
 
    inputs = {