Code review comment for lp:~widelands-dev/widelands/warehouse_fix

Revision history for this message
SirVer (sirver) wrote :

I am slightly confused. Why does it say this is merged? Trunk does definitely not contain the new code. Could it be that you branched and merged your different branches from each other instead from trunk?

however, the code looks fine. Just a nit

upcast(Warehouse, wh, building);
if (wh)

can be written as

if (upcast(Warehouse, wh, building))

review: Approve

« Back to merge proposal