Code review comment for lp:~widelands-dev/widelands/toggle_resources
Revision history for this message
| SirVer (sirver) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> the 'q' key is targeted as a shortcut for the resource view button
done.
> issue: the resource editing tool has to be deactivated while the RESOURCE VIEW is switched OFF. Deactivated means it must not be possible to create or remove any resources on the map.
I disagree with this design for two reasons:
1) precedence: right now it is already possible to change stuff with UI disabled. For example you can change terrain and this changes the buildhelp even if it is toggled off. You can also add/remove port spaces without the buildhelp being enabled.
2) mental model: right now, the editor is simple: you have exactly one tool selected and you can toggle some visualization (buildhelp) on and off. Both are independent. Now we add a new toggle for another visualization (resources), but it is another toggle, not bound to any of the other state.
If you now make some tools dependent on which visualization is toggled on you get a decision tree that the user has to understand first. I argue this is more complex in code and more complex to use.