Merge lp:~widelands-dev/widelands/spinbox into lp:widelands
Proposed by
GunChleoc
Status: | Merged |
---|---|
Approved by: | kaputtnik |
Approved revision: | no longer in the source branch. |
Merged at revision: | 7662 |
Proposed branch: | lp:~widelands-dev/widelands/spinbox |
Merge into: | lp:widelands |
Diff against target: |
376 lines (+94/-69) 6 files modified
src/ui_basic/spinbox.cc (+46/-20) src/ui_basic/spinbox.h (+5/-1) src/ui_basic/textarea.cc (+10/-1) src/ui_basic/textarea.h (+8/-1) src/ui_fsmenu/options.cc (+25/-42) src/ui_fsmenu/options.h (+0/-4) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands/spinbox |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Widelands Developers | Pending | ||
Review via email: mp+279153@code.launchpad.net |
Description of the change
Cleaned up buggy text positioning and width for spinboxes. Also, spinboxes now own their labels, just like checkboxes.
Labels will automatically take up more than 1 line if needed - we don't have a test case for this right now, but it safeguards us against text overflow with translations.
For testing: Spinboxes are only used in the Options window so far.
To post a comment you must log in.
Code looks good to me as far as I can tell, please test it somebody...