Code review comment for lp:~widelands-dev/widelands/rtl_wordwrap

Revision history for this message
GunChleoc (gunchleoc) wrote :

The text truncation problem should be fixed now, at the expense of efficiency. I am planning to use the word_wrap algorithm in editboxes only, so the efficiency won't be that much of a problem. I would like to keep it in the multiline-textarea for a bit though, so it will get more testing exposure.

Note that the caret rendering in the ediboxes for RTL languages is broken, but it didn't work before either, so it's not a regression.

The best test case is the map descriptions when loading a new map. This should be tested at various screen resolutions with our own language, English, Arabic and Jaoanese (= Nihongo, that's the language entry below Nederlands). You should also be able to navigate around text and type in the Editor Map Options like before.

review: Needs Resubmitting

« Back to merge proposal