Code review comment for lp:~widelands-dev/widelands/robust-file-saving

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

OK, I did some tests with normal saves and some ways to break it.
Experience tells me that Windows is more picky about such errors
(as it locks open files). I was unable to reproduce all the errors.
But anway, basic Saving is ok and nothing is broken.

The code looks ok for me so it can go in.

Gun: Do we have somone on Widows to do some more debugging?

I could spend some more time and try to break mores tuff :-)

review: Approve (compile, test, debug)

« Back to merge proposal