Merge lp:~widelands-dev/widelands/remove_signals into lp:widelands
Proposed by
Tino
Status: | Merged |
---|---|
Merged at revision: | 6821 |
Proposed branch: | lp:~widelands-dev/widelands/remove_signals |
Merge into: | lp:widelands |
Diff against target: |
46 lines (+8/-12) 1 file modified
CMakeLists.txt (+8/-12) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands/remove_signals |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
SirVer | Approve | ||
Review via email: mp+200501@code.launchpad.net |
Description of the change
I am proposing to merge this branch before b18, because:
- the CMake change regarding boost signals library is overdue. With the current state you are forced to compile the signals library to make the build work, even when it is not going to be linked.
- the activiation for the large address space on win32 should be safe. It was included in the windows test builds now for 5 weeks.
To post a comment you must log in.
I agree on both issues. The windows thingy could even be seen as a bug fix and the other is definitively a build bug fix.