Code review comment for lp:~widelands-dev/widelands/refactor_gameclient

Revision history for this message
GunChleoc (gunchleoc) wrote :

You could also do the game tips like this:

    const std::string tribename = get_players_tribe();
    assert(Widelands::tribe_exists(tribename));
    std::unique_ptr<GameTips> tips(new GameTips(*loader, {"general_game", "multiplayer", tribename}));

As to the ASan crash, I suspect that there is a problem with the lifetime of an object caused by the pulling out of stuff into separate functions.

« Back to merge proposal