Merge lp:~widelands-dev/widelands/productivity-string-fixes into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 8671
Proposed branch: lp:~widelands-dev/widelands/productivity-string-fixes
Merge into: lp:widelands
Diff against target: 497 lines (+118/-76)
26 files modified
data/tribes/buildings/militarysites/frisians/fortress/helptexts.lua (+7/-4)
data/tribes/buildings/militarysites/frisians/outpost/helptexts.lua (+7/-4)
data/tribes/buildings/militarysites/frisians/sentinel/helptexts.lua (+7/-4)
data/tribes/buildings/militarysites/frisians/tower/helptexts.lua (+7/-4)
data/tribes/buildings/militarysites/frisians/wooden_tower/helptexts.lua (+7/-4)
data/tribes/buildings/productionsites/frisians/bakery/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/barracks/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/brewery/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/brick_kiln/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/charcoal_kiln/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/coalmine/helptexts.lua (+8/-5)
data/tribes/buildings/productionsites/frisians/coalmine_deep/helptexts.lua (+8/-5)
data/tribes/buildings/productionsites/frisians/goldmine/helptexts.lua (+8/-5)
data/tribes/buildings/productionsites/frisians/goldmine_deep/helptexts.lua (+8/-5)
data/tribes/buildings/productionsites/frisians/ironmine/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/ironmine_deep/helptexts.lua (+8/-5)
data/tribes/buildings/productionsites/frisians/rockmine/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/rockmine_deep/helptexts.lua (+10/-7)
data/tribes/buildings/productionsites/frisians/sewing_room/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/smokery/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/weaving_mill/helptexts.lua (+1/-1)
data/tribes/buildings/productionsites/frisians/well/helptexts.lua (+1/-1)
data/tribes/buildings/warehouses/frisians/headquarters/helptexts.lua (+7/-4)
data/tribes/buildings/warehouses/frisians/port/helptexts.lua (+7/-4)
data/tribes/buildings/warehouses/frisians/warehouse/helptexts.lua (+7/-4)
To merge this branch: bzr merge lp:~widelands-dev/widelands/productivity-string-fixes
Reviewer Review Type Date Requested Status
Widelands Developers Pending
Review via email: mp+344796@code.launchpad.net

Commit message

Some string fixes for the Frisian helptexts

- Got rid of empty translation strings
- Added 'on average' to productivity helptexts, to be consistent with the other tribes

To post a comment you must log in.
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Changes Look good to me. Just one small question. Why did you insert the # sing after translators

Revision history for this message
GunChleoc (gunchleoc) wrote :

Our script to pick up Lua messages does not like it if there are translators' comments without translations.

Thanks for the review :)

@bunnybot merge

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

ok understood. But shouldn't the # be removed if there is a helptext defined? see inline comment

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 3429. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/373541678.
Appveyor build 3234. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_productivity_string_fixes-3234.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Yes they should. Strings are long enough though for this not to be
critical, so let's fix these as we go along?

Sgrìobh hessenfarmer na leanas 01/05/2018 aig 17:20:
> ok understood. But shouldn't the # be removed if there is a helptext defined? see inline comment
>
> Diff comments:
>
>>
>> === modified file 'data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua'
>> --- data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua 2018-02-17 15:41:29 +0000
>> +++ data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua 2018-04-28 06:28:06 +0000
>> @@ -20,5 +20,5 @@
>>
>> function building_helptext_performance()
>> -- TRANSLATORS#: Performance helptext for a building
>> - return pgettext("frisians_building", "The blacksmith needs %s to produce one tool."):bformat(ngettext("%d second", "%d seconds", 67):bformat(67))
>
> shouldn't the # sign after translators be removed as there is a helptext to translate?
>
>> + return pgettext("frisians_building", "The blacksmith needs %s on average to produce one tool."):bformat(ngettext("%d second", "%d seconds", 67):bformat(67))
>> end
>
>

--
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v2.0.22 (MingW32)

mQINBFNbSyEBEADh+uhohycnZgPPnyMs5pZQG6pKyLzFZoIKbVjY31ZoPZ2SdltB
elrwn6kFZkQiDx4K6nkZFHsPh8RMvWoFWg1rGiWkdsZessLFawraC8YEZDwtlaU5
SFXbE4+QnMfbPhe9tmC8Nbhec3dfV9zcXAhxc+zkIUsKFhSkpJ2Syvo9FCA/5adW
UZgWWKFwlSg4+/lrhJ6QJnldPlXfWcuEasKF7fjdafDIdS5hdKu8Lv+CiPQWvgsi
J2BDlZLzEZf3PD+NMujUbJa0nilD2ltu3/qRvR2f86YV6wRwt4E2OD8JJQOau4X2
Pg7vqkIbnB9rMiQ6T17rQ4rc80eesGCxQ6XOba9oa1eRRZDwY7HJtYwvPdw9HZaN
Lq2RRbGDGO0q7fxrzbp1WuNN+UXOA/pmVzWWczPfPHVcNIehGf3wQI+Vgh/qa+IZ
jLJ25I1Tv85cDzvv5gdtI8PR4JTfK6Db+gUJmsuIg2fmsljxA7OmeTgSPR7nEVq5
VlHYfx1T0uKlthWw/eDwlS44vTgm6HZzIdYqdPMPa/PU1U+WVuDejyDJTn/1TY78
oJMT/IixFR+N+smohhKASprewcsO2ClWGptSG0sRTiCrVHFD3Mt6SCVaxsQLHvek
KuNAUXhR2KSvYuqGT0Nv3bplN6svCp4CuAGZ3lyOIt/Sb7OFUwzcx2sOdwARAQAB
tC5Gw7JyYW0gbmEgR8OgaWRobGlnIDxmaW9zQGZvcmFtbmFnYWlkaGxpZy5uZXQ+
iQI5BBMBAgAjBQJTW0shAhsPBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQ
UHP09XBr75NHNBAAxv2C/G13Z1kCFOSOnbPpzqcIDcMuP7RK1Mv5XfOZLfqSw4le
gdDmZggX2/EBH6xFTXFPLSE6rVUKTkHLA7IY8D43GBtDWjcIyyuLnIjtR+LhRKCP
3/Sm8MyZMQvUH1CBpUXFNnP/HCR6xjm1Mog5kXxFeCR9PMjeEiobKXIVuMfuNlBD
WzoR2Nh+oroXLjZw3VMFewiCyhu4Pe7F3sLpVldiI3PBOyPQOBZ3HEIM490D/Lrh
rl3Wwmoug8j8rqkh/Fr+kKaToRJik4PkcxsfepzhMdNfCpr7I3jE5XQHzib5Ubv8
wsSaVNBG92NTnGKoAntWXBUaiDN84St9l+Zm/BgedRk+7wdESHBuOuFXoRc0yEjF
4tLOhyO9u5bYGQWHyJiwhbw51R8G+Kh3OPq/tr4KmsuueEI2v5cLkoDzwCpYyMnu
BfU8d0mt5eULbQCWcy7LYeQs6E+CEB+tPL3Qz2zaAAvwt7N2PLMjHf5Fcqj5LqrV
mzQfcB9zQFq9Rtld/IIIDkE1y/q/SNFYsFNW/u/bxWsu+lMOYtBco++O5DJhAq6t
7rJXUBirju50hhogHfBL2v6RG1b8/uiWm0m8713ZhiSvpr4Dd+V+DU9nPli5nTmU
En6gP7TTYJKETMf7O9i873Z8yG6zd0/fBzFyruS2KRTPV2GiVT6CI37gUtw=
=fcOW
-----END PGP PUBLIC KEY BLOCK-----

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Thanks, unfortunately Transifex still showed some empty strings for the ironmine and another mine as far as I remember

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/tribes/buildings/militarysites/frisians/fortress/helptexts.lua'
2--- data/tribes/buildings/militarysites/frisians/fortress/helptexts.lua 2018-01-22 13:40:13 +0000
3+++ data/tribes/buildings/militarysites/frisians/fortress/helptexts.lua 2018-04-28 06:28:06 +0000
4@@ -1,11 +1,14 @@
5+-- This include can be removed when all help texts have been defined.
6+include "tribes/scripting/help/global_helptexts.lua"
7+
8 function building_helptext_lore ()
9- -- TRANSLATORS: Lore helptext for a building
10- return pgettext ("frisians_building", "")
11+ -- TRANSLATORS#: Lore helptext for a building
12+ return no_lore_text_yet()
13 end
14
15 function building_helptext_lore_author ()
16- -- TRANSLATORS: Lore author helptext for a building
17- return pgettext ("frisians_building", "")
18+ -- TRANSLATORS#: Lore author helptext for a building
19+ return no_lore_author_text_yet()
20 end
21
22 function building_helptext_purpose()
23
24=== modified file 'data/tribes/buildings/militarysites/frisians/outpost/helptexts.lua'
25--- data/tribes/buildings/militarysites/frisians/outpost/helptexts.lua 2018-01-22 13:40:13 +0000
26+++ data/tribes/buildings/militarysites/frisians/outpost/helptexts.lua 2018-04-28 06:28:06 +0000
27@@ -1,11 +1,14 @@
28+-- This include can be removed when all help texts have been defined.
29+include "tribes/scripting/help/global_helptexts.lua"
30+
31 function building_helptext_lore ()
32- -- TRANSLATORS: Lore helptext for a building
33- return pgettext ("frisians_building", "")
34+ -- TRANSLATORS#: Lore helptext for a building
35+ return no_lore_text_yet()
36 end
37
38 function building_helptext_lore_author ()
39- -- TRANSLATORS: Lore author helptext for a building
40- return pgettext ("frisians_building", "")
41+ -- TRANSLATORS#: Lore author helptext for a building
42+ return no_lore_author_text_yet()
43 end
44
45 function building_helptext_purpose()
46
47=== modified file 'data/tribes/buildings/militarysites/frisians/sentinel/helptexts.lua'
48--- data/tribes/buildings/militarysites/frisians/sentinel/helptexts.lua 2018-01-22 13:40:13 +0000
49+++ data/tribes/buildings/militarysites/frisians/sentinel/helptexts.lua 2018-04-28 06:28:06 +0000
50@@ -1,11 +1,14 @@
51+-- This include can be removed when all help texts have been defined.
52+include "tribes/scripting/help/global_helptexts.lua"
53+
54 function building_helptext_lore ()
55- -- TRANSLATORS: Lore helptext for a building
56- return pgettext ("frisians_building", "")
57+ -- TRANSLATORS#: Lore helptext for a building
58+ return no_lore_text_yet()
59 end
60
61 function building_helptext_lore_author ()
62- -- TRANSLATORS: Lore author helptext for a building
63- return pgettext ("frisians_building", "")
64+ -- TRANSLATORS#: Lore author helptext for a building
65+ return no_lore_author_text_yet()
66 end
67
68 function building_helptext_purpose()
69
70=== modified file 'data/tribes/buildings/militarysites/frisians/tower/helptexts.lua'
71--- data/tribes/buildings/militarysites/frisians/tower/helptexts.lua 2018-01-22 13:40:13 +0000
72+++ data/tribes/buildings/militarysites/frisians/tower/helptexts.lua 2018-04-28 06:28:06 +0000
73@@ -1,11 +1,14 @@
74+-- This include can be removed when all help texts have been defined.
75+include "tribes/scripting/help/global_helptexts.lua"
76+
77 function building_helptext_lore ()
78- -- TRANSLATORS: Lore helptext for a building
79- return pgettext ("frisians_building", "")
80+ -- TRANSLATORS#: Lore helptext for a building
81+ return no_lore_text_yet()
82 end
83
84 function building_helptext_lore_author ()
85- -- TRANSLATORS: Lore author helptext for a building
86- return pgettext ("frisians_building", "")
87+ -- TRANSLATORS#: Lore author helptext for a building
88+ return no_lore_author_text_yet()
89 end
90
91 function building_helptext_purpose()
92
93=== modified file 'data/tribes/buildings/militarysites/frisians/wooden_tower/helptexts.lua'
94--- data/tribes/buildings/militarysites/frisians/wooden_tower/helptexts.lua 2018-01-22 13:40:13 +0000
95+++ data/tribes/buildings/militarysites/frisians/wooden_tower/helptexts.lua 2018-04-28 06:28:06 +0000
96@@ -1,11 +1,14 @@
97+-- This include can be removed when all help texts have been defined.
98+include "tribes/scripting/help/global_helptexts.lua"
99+
100 function building_helptext_lore ()
101- -- TRANSLATORS: Lore helptext for a building
102- return pgettext ("frisians_building", "")
103+ -- TRANSLATORS#: Lore helptext for a building
104+ return no_lore_text_yet()
105 end
106
107 function building_helptext_lore_author ()
108- -- TRANSLATORS: Lore author helptext for a building
109- return pgettext ("frisians_building", "")
110+ -- TRANSLATORS#: Lore author helptext for a building
111+ return no_lore_author_text_yet()
112 end
113
114 function building_helptext_purpose()
115
116=== modified file 'data/tribes/buildings/productionsites/frisians/bakery/helptexts.lua'
117--- data/tribes/buildings/productionsites/frisians/bakery/helptexts.lua 2018-02-17 15:41:29 +0000
118+++ data/tribes/buildings/productionsites/frisians/bakery/helptexts.lua 2018-04-28 06:28:06 +0000
119@@ -20,5 +20,5 @@
120
121 function building_helptext_performance()
122 -- TRANSLATORS#: Performance helptext for a building
123- return pgettext("frisians_building", "The bakery needs %s to produce one loaf of bread."):bformat(ngettext("%d second", "%d seconds", 40):bformat(40))
124+ return pgettext("frisians_building", "The bakery needs %s on average to produce one loaf of bread."):bformat(ngettext("%d second", "%d seconds", 40):bformat(40))
125 end
126
127=== modified file 'data/tribes/buildings/productionsites/frisians/barracks/helptexts.lua'
128--- data/tribes/buildings/productionsites/frisians/barracks/helptexts.lua 2018-04-03 14:47:34 +0000
129+++ data/tribes/buildings/productionsites/frisians/barracks/helptexts.lua 2018-04-28 06:28:06 +0000
130@@ -20,5 +20,5 @@
131
132 function building_helptext_performance()
133 -- #TRANSLATORS: Performance helptext for a building
134- return pgettext("frisians_building", "The barracks needs %s to recruit one soldier."):bformat(ngettext("%d second", "%d seconds", 30):bformat(30))
135+ return pgettext("frisians_building", "The barracks needs %s on average to recruit one soldier."):bformat(ngettext("%d second", "%d seconds", 30):bformat(30))
136 end
137
138=== modified file 'data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua'
139--- data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua 2018-02-17 15:41:29 +0000
140+++ data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua 2018-04-28 06:28:06 +0000
141@@ -20,5 +20,5 @@
142
143 function building_helptext_performance()
144 -- TRANSLATORS#: Performance helptext for a building
145- return pgettext("frisians_building", "The blacksmith needs %s to produce one tool."):bformat(ngettext("%d second", "%d seconds", 67):bformat(67))
146+ return pgettext("frisians_building", "The blacksmith needs %s on average to produce one tool."):bformat(ngettext("%d second", "%d seconds", 67):bformat(67))
147 end
148
149=== modified file 'data/tribes/buildings/productionsites/frisians/brewery/helptexts.lua'
150--- data/tribes/buildings/productionsites/frisians/brewery/helptexts.lua 2018-02-17 15:41:29 +0000
151+++ data/tribes/buildings/productionsites/frisians/brewery/helptexts.lua 2018-04-28 06:28:06 +0000
152@@ -20,5 +20,5 @@
153
154 function building_helptext_performance()
155 -- TRANSLATORS#: Performance helptext for a building
156- return pgettext("frisians_building", "The brewery needs %s to brew one mug of beer."):bformat(ngettext("%d second", "%d seconds", 60):bformat(60))
157+ return pgettext("frisians_building", "The brewery needs %s on average to brew one mug of beer."):bformat(ngettext("%d second", "%d seconds", 60):bformat(60))
158 end
159
160=== modified file 'data/tribes/buildings/productionsites/frisians/brick_kiln/helptexts.lua'
161--- data/tribes/buildings/productionsites/frisians/brick_kiln/helptexts.lua 2018-03-06 09:50:54 +0000
162+++ data/tribes/buildings/productionsites/frisians/brick_kiln/helptexts.lua 2018-04-28 06:28:06 +0000
163@@ -20,5 +20,5 @@
164
165 function building_helptext_performance()
166 -- TRANSLATORS#: Performance helptext for a building
167- return pgettext("frisians_building", "The brick kiln needs %s to produce two bricks."):bformat(ngettext("%d second", "%d seconds", 78):bformat(78))
168+ return pgettext("frisians_building", "The brick kiln needs %s on average to produce two bricks."):bformat(ngettext("%d second", "%d seconds", 78):bformat(78))
169 end
170
171=== modified file 'data/tribes/buildings/productionsites/frisians/charcoal_kiln/helptexts.lua'
172--- data/tribes/buildings/productionsites/frisians/charcoal_kiln/helptexts.lua 2018-01-22 13:40:13 +0000
173+++ data/tribes/buildings/productionsites/frisians/charcoal_kiln/helptexts.lua 2018-04-28 06:28:06 +0000
174@@ -20,5 +20,5 @@
175
176 function building_helptext_performance()
177 -- TRANSLATORS#: Performance helptext for a building
178- return pgettext("frisians_building", "The charcoal kiln needs %s to produce one coal."):bformat(ngettext("%d second", "%d seconds", 60):bformat(60))
179+ return pgettext("frisians_building", "The charcoal kiln needs %s on average to produce one coal."):bformat(ngettext("%d second", "%d seconds", 60):bformat(60))
180 end
181
182=== modified file 'data/tribes/buildings/productionsites/frisians/coalmine/helptexts.lua'
183--- data/tribes/buildings/productionsites/frisians/coalmine/helptexts.lua 2018-01-22 13:40:13 +0000
184+++ data/tribes/buildings/productionsites/frisians/coalmine/helptexts.lua 2018-04-28 06:28:06 +0000
185@@ -1,11 +1,14 @@
186+-- This include can be removed when all help texts have been defined.
187+include "tribes/scripting/help/global_helptexts.lua"
188+
189 function building_helptext_lore ()
190- -- TRANSLATORS: Lore helptext for a building
191- return pgettext ("frisians_building", "")
192+ -- TRANSLATORS#: Lore helptext for a building
193+ return no_lore_text_yet()
194 end
195
196 function building_helptext_lore_author ()
197- -- TRANSLATORS: Lore author helptext for a building
198- return pgettext ("frisians_building", "")
199+ -- TRANSLATORS#: Lore author helptext for a building
200+ return no_lore_author_text_yet()
201 end
202
203 function building_helptext_purpose()
204@@ -20,5 +23,5 @@
205
206 function building_helptext_performance()
207 -- TRANSLATORS: Performance helptext for a building
208- return pgettext("frisians_building", "The coal mine needs %s to produce two pieces of coal."):bformat(ngettext("%d second", "%d seconds", 85):bformat(85))
209+ return pgettext("frisians_building", "If the food supply is steady, the coal mine can produce two pieces of coal in %s on average."):bformat(ngettext("%d second", "%d seconds", 85):bformat(85))
210 end
211
212=== modified file 'data/tribes/buildings/productionsites/frisians/coalmine_deep/helptexts.lua'
213--- data/tribes/buildings/productionsites/frisians/coalmine_deep/helptexts.lua 2018-01-22 13:40:13 +0000
214+++ data/tribes/buildings/productionsites/frisians/coalmine_deep/helptexts.lua 2018-04-28 06:28:06 +0000
215@@ -1,11 +1,14 @@
216+-- This include can be removed when all help texts have been defined.
217+include "tribes/scripting/help/global_helptexts.lua"
218+
219 function building_helptext_lore ()
220- -- TRANSLATORS: Lore helptext for a building
221- return pgettext ("frisians_building", "")
222+ -- TRANSLATORS#: Lore helptext for a building
223+ return no_lore_text_yet()
224 end
225
226 function building_helptext_lore_author ()
227- -- TRANSLATORS: Lore author helptext for a building
228- return pgettext ("frisians_building", "")
229+ -- TRANSLATORS#: Lore author helptext for a building
230+ return no_lore_author_text_yet()
231 end
232
233 function building_helptext_purpose()
234@@ -20,5 +23,5 @@
235
236 function building_helptext_performance()
237 -- TRANSLATORS: Performance helptext for a building
238- return pgettext("frisians_building", "The deep coal mine needs %s to produce four pieces of coal."):bformat(ngettext("%d second", "%d seconds", 76):bformat(76))
239+ return pgettext("frisians_building", "If the food supply is steady, the deep coal mine can produce four pieces of coal in %s on average."):bformat(ngettext("%d second", "%d seconds", 76):bformat(76))
240 end
241
242=== modified file 'data/tribes/buildings/productionsites/frisians/goldmine/helptexts.lua'
243--- data/tribes/buildings/productionsites/frisians/goldmine/helptexts.lua 2018-01-22 13:40:13 +0000
244+++ data/tribes/buildings/productionsites/frisians/goldmine/helptexts.lua 2018-04-28 06:28:06 +0000
245@@ -1,11 +1,14 @@
246+-- This include can be removed when all help texts have been defined.
247+include "tribes/scripting/help/global_helptexts.lua"
248+
249 function building_helptext_lore ()
250- -- TRANSLATORS: Lore helptext for a building
251- return pgettext ("frisians_building", "")
252+ -- TRANSLATORS#: Lore helptext for a building
253+ return no_lore_text_yet()
254 end
255
256 function building_helptext_lore_author ()
257- -- TRANSLATORS: Lore author helptext for a building
258- return pgettext ("frisians_building", "")
259+ -- TRANSLATORS#: Lore author helptext for a building
260+ return no_lore_author_text_yet()
261 end
262
263 function building_helptext_purpose()
264@@ -20,5 +23,5 @@
265
266 function building_helptext_performance()
267 -- TRANSLATORS: Performance helptext for a building
268- return pgettext("frisians_building", "The gold mine needs %s to produce one piece of gold ore."):bformat(ngettext("%d second", "%d seconds", 65):bformat(65))
269+ return pgettext("frisians_building", "If the food supply is steady, the gold mine can produce one piece of gold ore in %s on average."):bformat(ngettext("%d second", "%d seconds", 65):bformat(65))
270 end
271
272=== modified file 'data/tribes/buildings/productionsites/frisians/goldmine_deep/helptexts.lua'
273--- data/tribes/buildings/productionsites/frisians/goldmine_deep/helptexts.lua 2018-01-22 13:40:13 +0000
274+++ data/tribes/buildings/productionsites/frisians/goldmine_deep/helptexts.lua 2018-04-28 06:28:06 +0000
275@@ -1,11 +1,14 @@
276+-- This include can be removed when all help texts have been defined.
277+include "tribes/scripting/help/global_helptexts.lua"
278+
279 function building_helptext_lore ()
280- -- TRANSLATORS: Lore helptext for a building
281- return pgettext ("frisians_building", "")
282+ -- TRANSLATORS#: Lore helptext for a building
283+ return no_lore_text_yet()
284 end
285
286 function building_helptext_lore_author ()
287- -- TRANSLATORS: Lore author helptext for a building
288- return pgettext ("frisians_building", "")
289+ -- TRANSLATORS#: Lore author helptext for a building
290+ return no_lore_author_text_yet()
291 end
292
293 function building_helptext_purpose()
294@@ -20,5 +23,5 @@
295
296 function building_helptext_performance()
297 -- TRANSLATORS: Performance helptext for a building
298- return pgettext("frisians_building", "The deep gold mine needs %s to produce two pieces of gold ore."):bformat(ngettext("%d second", "%d seconds", 76):bformat(76))
299+ return pgettext("frisians_building", "If the food supply is steady, the deep gold mine can produce two pieces of gold ore in %s on average."):bformat(ngettext("%d second", "%d seconds", 76):bformat(76))
300 end
301
302=== modified file 'data/tribes/buildings/productionsites/frisians/ironmine/helptexts.lua'
303--- data/tribes/buildings/productionsites/frisians/ironmine/helptexts.lua 2018-01-22 13:40:13 +0000
304+++ data/tribes/buildings/productionsites/frisians/ironmine/helptexts.lua 2018-04-28 06:28:06 +0000
305@@ -20,5 +20,5 @@
306
307 function building_helptext_performance()
308 -- TRANSLATORS: Performance helptext for a building
309- return pgettext("frisians_building", "The iron mine needs %s to produce one piece of iron ore."):bformat(ngettext("%d second", "%d seconds", 65):bformat(65))
310+ return pgettext("frisians_building", "If the food supply is steady, the iron mine can produce one piece of iron ore in %s on average."):bformat(ngettext("%d second", "%d seconds", 65):bformat(65))
311 end
312
313=== modified file 'data/tribes/buildings/productionsites/frisians/ironmine_deep/helptexts.lua'
314--- data/tribes/buildings/productionsites/frisians/ironmine_deep/helptexts.lua 2018-01-22 13:40:13 +0000
315+++ data/tribes/buildings/productionsites/frisians/ironmine_deep/helptexts.lua 2018-04-28 06:28:06 +0000
316@@ -1,11 +1,14 @@
317+-- This include can be removed when all help texts have been defined.
318+include "tribes/scripting/help/global_helptexts.lua"
319+
320 function building_helptext_lore ()
321- -- TRANSLATORS: Lore helptext for a building
322- return pgettext ("frisians_building", "")
323+ -- TRANSLATORS#: Lore helptext for a building
324+ return no_lore_text_yet()
325 end
326
327 function building_helptext_lore_author ()
328- -- TRANSLATORS: Lore author helptext for a building
329- return pgettext ("frisians_building", "")
330+ -- TRANSLATORS#: Lore author helptext for a building
331+ return no_lore_author_text_yet()
332 end
333
334 function building_helptext_purpose()
335@@ -20,5 +23,5 @@
336
337 function building_helptext_performance()
338 -- TRANSLATORS: Performance helptext for a building
339- return pgettext("frisians_building", "The deep iron mine needs %s to produce two pieces of iron ore."):bformat(ngettext("%d second", "%d seconds", 76):bformat(76))
340+ return pgettext("frisians_building", "If the food supply is steady, the deep iron mine can produce two pieces of iron ore in %s on average."):bformat(ngettext("%d second", "%d seconds", 76):bformat(76))
341 end
342
343=== modified file 'data/tribes/buildings/productionsites/frisians/rockmine/helptexts.lua'
344--- data/tribes/buildings/productionsites/frisians/rockmine/helptexts.lua 2018-01-22 13:40:13 +0000
345+++ data/tribes/buildings/productionsites/frisians/rockmine/helptexts.lua 2018-04-28 06:28:06 +0000
346@@ -20,5 +20,5 @@
347
348 function building_helptext_performance()
349 -- TRANSLATORS: Performance helptext for a building
350- return pgettext("frisians_building", "The rock mine needs %s to produce two blocks of granite."):bformat(ngettext("%d second", "%d seconds", 85):bformat(85))
351+ return pgettext("frisians_building", "If the food supply is steady, the rock mine can produce two blocks of granite in %s on average."):bformat(ngettext("%d second", "%d seconds", 85):bformat(85))
352 end
353
354=== modified file 'data/tribes/buildings/productionsites/frisians/rockmine_deep/helptexts.lua'
355--- data/tribes/buildings/productionsites/frisians/rockmine_deep/helptexts.lua 2018-01-22 13:40:13 +0000
356+++ data/tribes/buildings/productionsites/frisians/rockmine_deep/helptexts.lua 2018-04-28 06:28:06 +0000
357@@ -1,11 +1,14 @@
358-function building_helptext_lore()
359- -- TRANSLATORS: Lore helptext for a building
360- return pgettext ("frisians_building", "")
361+-- This include can be removed when all help texts have been defined.
362+include "tribes/scripting/help/global_helptexts.lua"
363+
364+function building_helptext_lore ()
365+ -- TRANSLATORS#: Lore helptext for a building
366+ return no_lore_text_yet()
367 end
368
369-function building_helptext_lore_author()
370- -- TRANSLATORS: Lore author helptext for a building
371- return pgettext ("frisians_building", "")
372+function building_helptext_lore_author ()
373+ -- TRANSLATORS#: Lore author helptext for a building
374+ return no_lore_author_text_yet()
375 end
376
377 function building_helptext_purpose()
378@@ -20,5 +23,5 @@
379
380 function building_helptext_performance()
381 -- TRANSLATORS: Performance helptext for a building
382- return pgettext("frisians_building", "The deep rock mine needs %s to produce three blocks of granite."):bformat(ngettext("%d second", "%d seconds", 76):bformat(76))
383+ return pgettext("frisians_building", "If the food supply is steady, the deep rock mine can produce three blocks of granite in %s on average."):bformat(ngettext("%d second", "%d seconds", 76):bformat(76))
384 end
385
386=== modified file 'data/tribes/buildings/productionsites/frisians/sewing_room/helptexts.lua'
387--- data/tribes/buildings/productionsites/frisians/sewing_room/helptexts.lua 2018-02-19 08:50:22 +0000
388+++ data/tribes/buildings/productionsites/frisians/sewing_room/helptexts.lua 2018-04-28 06:28:06 +0000
389@@ -20,5 +20,5 @@
390
391 function building_helptext_performance()
392 -- TRANSLATORS#: Performance helptext for a building
393- return pgettext("frisians_building", "The sewing room needs %s to produce one fur garment."):bformat(ngettext("%d second", "%d seconds", 45):bformat(45))
394+ return pgettext("frisians_building", "The sewing room needs %s on average to produce one fur garment."):bformat(ngettext("%d second", "%d seconds", 45):bformat(45))
395 end
396
397=== modified file 'data/tribes/buildings/productionsites/frisians/smokery/helptexts.lua'
398--- data/tribes/buildings/productionsites/frisians/smokery/helptexts.lua 2018-02-17 15:41:29 +0000
399+++ data/tribes/buildings/productionsites/frisians/smokery/helptexts.lua 2018-04-28 06:28:06 +0000
400@@ -20,5 +20,5 @@
401
402 function building_helptext_performance()
403 -- TRANSLATORS#: Performance helptext for a building
404- return pgettext("frisians_building", "The smokery needs %s to smoke two fish or two meat."):bformat(ngettext("%d second", "%d seconds", 46):bformat(46))
405+ return pgettext("frisians_building", "The smokery needs %s on average to smoke two fish or two meat."):bformat(ngettext("%d second", "%d seconds", 46):bformat(46))
406 end
407
408=== modified file 'data/tribes/buildings/productionsites/frisians/weaving_mill/helptexts.lua'
409--- data/tribes/buildings/productionsites/frisians/weaving_mill/helptexts.lua 2018-04-06 06:43:31 +0000
410+++ data/tribes/buildings/productionsites/frisians/weaving_mill/helptexts.lua 2018-04-28 06:28:06 +0000
411@@ -20,5 +20,5 @@
412
413 function building_helptext_performance()
414 -- TRANSLATORS#: Performance helptext for a building
415- return pgettext("frisians_building", "The weaving mill needs %s to produce one piece of cloth."):bformat(ngettext("%d second", "%d seconds", 45):bformat(45))
416+ return pgettext("frisians_building", "The weaving mill needs %s on average to produce one piece of cloth."):bformat(ngettext("%d second", "%d seconds", 45):bformat(45))
417 end
418
419=== modified file 'data/tribes/buildings/productionsites/frisians/well/helptexts.lua'
420--- data/tribes/buildings/productionsites/frisians/well/helptexts.lua 2018-02-17 15:41:29 +0000
421+++ data/tribes/buildings/productionsites/frisians/well/helptexts.lua 2018-04-28 06:28:06 +0000
422@@ -15,5 +15,5 @@
423
424 function building_helptext_performance()
425 -- TRANSLATORS: Performance helptext for a building
426- return pgettext("frisians_building", "The well needs %s to produce one bucket of water."):bformat(ngettext("%d second", "%d seconds", 40):bformat(40))
427+ return pgettext("frisians_building", "The well needs %s on average to produce one bucket of water."):bformat(ngettext("%d second", "%d seconds", 40):bformat(40))
428 end
429
430=== modified file 'data/tribes/buildings/warehouses/frisians/headquarters/helptexts.lua'
431--- data/tribes/buildings/warehouses/frisians/headquarters/helptexts.lua 2018-01-22 13:40:13 +0000
432+++ data/tribes/buildings/warehouses/frisians/headquarters/helptexts.lua 2018-04-28 06:28:06 +0000
433@@ -1,11 +1,14 @@
434+-- This include can be removed when all help texts have been defined.
435+include "tribes/scripting/help/global_helptexts.lua"
436+
437 function building_helptext_lore ()
438- -- TRANSLATORS: Lore helptext for a building
439- return pgettext ("frisians_building", "")
440+ -- TRANSLATORS#: Lore helptext for a building
441+ return no_lore_text_yet()
442 end
443
444 function building_helptext_lore_author ()
445- -- TRANSLATORS: Lore author helptext for a building
446- return pgettext ("frisians_building", "")
447+ -- TRANSLATORS#: Lore author helptext for a building
448+ return no_lore_author_text_yet()
449 end
450
451 function building_helptext_purpose()
452
453=== modified file 'data/tribes/buildings/warehouses/frisians/port/helptexts.lua'
454--- data/tribes/buildings/warehouses/frisians/port/helptexts.lua 2018-01-22 13:40:13 +0000
455+++ data/tribes/buildings/warehouses/frisians/port/helptexts.lua 2018-04-28 06:28:06 +0000
456@@ -1,11 +1,14 @@
457+-- This include can be removed when all help texts have been defined.
458+include "tribes/scripting/help/global_helptexts.lua"
459+
460 function building_helptext_lore ()
461- -- TRANSLATORS: Lore helptext for a building
462- return pgettext ("frisians_building", "")
463+ -- TRANSLATORS#: Lore helptext for a building
464+ return no_lore_text_yet()
465 end
466
467 function building_helptext_lore_author ()
468- -- TRANSLATORS: Lore author helptext for a building
469- return pgettext ("frisians_building", "")
470+ -- TRANSLATORS#: Lore author helptext for a building
471+ return no_lore_author_text_yet()
472 end
473
474 function building_helptext_purpose()
475
476=== modified file 'data/tribes/buildings/warehouses/frisians/warehouse/helptexts.lua'
477--- data/tribes/buildings/warehouses/frisians/warehouse/helptexts.lua 2018-01-22 13:40:13 +0000
478+++ data/tribes/buildings/warehouses/frisians/warehouse/helptexts.lua 2018-04-28 06:28:06 +0000
479@@ -1,11 +1,14 @@
480+-- This include can be removed when all help texts have been defined.
481+include "tribes/scripting/help/global_helptexts.lua"
482+
483 function building_helptext_lore ()
484- -- TRANSLATORS: Lore helptext for a building
485- return pgettext ("frisians_building", "")
486+ -- TRANSLATORS#: Lore helptext for a building
487+ return no_lore_text_yet()
488 end
489
490 function building_helptext_lore_author ()
491- -- TRANSLATORS: Lore author helptext for a building
492- return pgettext ("frisians_building", "")
493+ -- TRANSLATORS#: Lore author helptext for a building
494+ return no_lore_author_text_yet()
495 end
496
497 function building_helptext_purpose()

Subscribers

People subscribed via source and target branches

to status/vote changes: