I have a question regarding this comment:
// NOCOM(#codereview): no need to be static? std::vector<TribeBasicInfo> Tribes::get_all_tribeinfos()
This function is used in the GameSettingsProvider classes before an egbase is created. Is there a better design than using static for this?
« Back to merge proposal
I have a question regarding this comment:
// NOCOM(#codereview): no need to be static? TribeBasicInfo> Tribes: :get_all_ tribeinfos( )
std::vector<
This function is used in the GameSettingsPro vider classes before an egbase is created. Is there a better design than using static for this?