Code review comment for lp:~widelands-dev/widelands/one_tribe

Revision history for this message
GunChleoc (gunchleoc) wrote :

I have a question regarding this comment:

// NOCOM(#codereview): no need to be static?
std::vector<TribeBasicInfo> Tribes::get_all_tribeinfos()

This function is used in the GameSettingsProvider classes before an egbase is created. Is there a better design than using static for this?

« Back to merge proposal