Merge lp:~widelands-dev/widelands/odd_locale_fix into lp:widelands

[Klaus Halfmann]

Fix undefined / unexpected behaviour in case LANG environment is empty.

Falback to 'en' in case LANG is empty

[Toni Förster (stonerl)]

Works forme, tested this on macOS 10.13.6.

review: Approve

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 3771. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/414931628.
Appveyor build 3570. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_odd_locale_fix-3570.

[GunChleoc (gunchleoc)]

Thanks!

Travis problems are from trunk.

@bunnybot merge force

=== modified file 'src/base/i18n.cc'
--- src/base/i18n.cc	2018-04-07 16:59:00 +0000
+++ src/base/i18n.cc	2018-08-11 18:17:57 +0000
@@ -145,7 +145,9 @@
 		lang = getenv("LANGUAGE");
 		if (lang != nullptr) {
 			env_locale = lang;
-		}
+        } else { // Finall fallback in case we cannot find out anything (#1784495)
+            env_locale = "en";
+        }
 	}
 	locale = "C";
 	SETLOCALE(LC_ALL, "C");