Merge lp:~widelands-dev/widelands/objective-string-rules into lp:widelands

Proposed by hessenfarmer
Status: Merged
Merged at revision: 8682
Proposed branch: lp:~widelands-dev/widelands/objective-string-rules
Merge into: lp:widelands
Diff against target: 108 lines (+18/-16)
1 file modified
data/campaigns/emp02.wmf/scripting/texts.lua (+18/-16)
To merge this branch: bzr merge lp:~widelands-dev/widelands/objective-string-rules
Reviewer Review Type Date Requested Status
hessenfarmer Approve
Review via email: mp+344918@code.launchpad.net

Commit message

Changed an objective in empire02 to be consistent with the rest of the campaign

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 3435. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/373681706.
Appveyor build 3240. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_objective_string_rules-3240.

Revision history for this message
GunChleoc (gunchleoc) wrote :

I have added some more tweaks - please review my changes and trigger the merge if they're OK.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Thanks a lot.

@bunnybot merge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/campaigns/emp02.wmf/scripting/texts.lua'
2--- data/campaigns/emp02.wmf/scripting/texts.lua 2018-02-15 15:43:53 +0000
3+++ data/campaigns/emp02.wmf/scripting/texts.lua 2018-05-03 06:31:12 +0000
4@@ -23,7 +23,7 @@
5 -- Objectives
6 -- ===========
7 obj_build_woodeconomy = {
8- name = "build_woodeconomy ",
9+ name = "build_woodeconomy",
10 title =_"Build up a wood economy",
11 number = 5,
12 body = objective_text(_"Wood Economy",
13@@ -32,7 +32,7 @@
14 }
15
16 obj_build_quarry = {
17- name = "build_quarry ",
18+ name = "build_quarry",
19 title =_"Build a quarry",
20 number = 1,
21 body = objective_text(_"Quarry",
22@@ -41,7 +41,7 @@
23 }
24
25 obj_build_military_buildings = {
26- name = "build_military_buildings ",
27+ name = "build_military_buildings",
28 title =_"Protect your colony",
29 number = 1,
30 body = objective_text(_"Protect Your Colony",
31@@ -50,7 +50,7 @@
32 }
33
34 obj_build_marblemine = {
35- name = "build_marblemine ",
36+ name = "build_marblemine",
37 title =_"Start mining marble",
38 number = 1,
39 body = objective_text(_"Marble",
40@@ -59,7 +59,7 @@
41 }
42
43 obj_build_mining_infrastructure = {
44- name = "build_mining_infrastructure ",
45+ name = "build_mining_infrastructure",
46 title =_"Build a stonemason’s house and mining infrastructure",
47 number = 7,
48 body = objective_text(_"Stonemason’s house and Mining Infrastructure",
49@@ -72,31 +72,33 @@
50 title =_"Provide your miners with food",
51 number = 1,
52 body = objective_text(_"Food For Your Miners",
53- li(_[[To produce some sustaining food for our miners, we could build up a tavern. To supply them with some good and strong drinks, we could build up a brewery and a winery.]]) ..
54- li(_[[Of course this means we will need more resources for preparing this food – like fish, meat or bread. To provide these foodstuffs, you would have to build a fisher’s house, a farm, a mill and a bakery.]]) ..
55- li(_[[Maybe you will also need a hunter’s house, a piggery, a vineyard and some wells.]]) ..
56+ li(_[[Build a tavern to produce some food to sustain our miners.]]) ..
57+ li_arrow(_[[Of course this means you will need more resources for preparing this food – like fish, meat or bread.]]) ..
58+ li_arrow(_[[To provide these foodstuffs, you can build a fisher’s house, a hunter’s house, a farm, a mill and a bakery.]]) ..
59+ li(_[[Build a brewery and a winery to supply the miners with some good and strong drinks.]]) ..
60+ li_arrow(_[[Maybe you will also need a piggery, a vineyard and some wells.]]) ..
61 li_arrow(_[[It’s up to you what you want to build. But remember – coal and iron mines need beer, marble and gold mines need wine and all mines need at least rations, which are produced out of bread OR meat OR fish.]])
62 ),
63 }
64
65 obj_build_bigger_military_buildings = {
66- name = "build_bigger_military_buildings ",
67+ name = "build_bigger_military_buildings",
68 title =_"Protect your eastern frontier",
69 number = 1,
70 body = objective_text(_"Protect Your Eastern Frontier",
71- li(_[[Build up stronger military buildings, such as an outpost, a barrier or a tower, on the eastern frontier.]]) ..
72- li_arrow(_[[To watch deep inside the enemy territory, build a tower.]])
73+ li(_[[Build stronger military buildings, such as an outpost, a barrier or a tower, on the eastern frontier.]]) ..
74+ li_arrow(_[[Build a tower to watch deep inside the enemy territory.]])
75 ),
76 }
77
78 obj_remove_the_barbarians = {
79- name = "remove_the_barbarians ",
80+ name = "remove_the_barbarians",
81 title =_"Destroy the Barbarian tribe",
82 number = 2,
83 body = objective_text(_"Destroy the Barbarian Tribe",
84 li(_[[Build a barracks to start training soldiers.]]) ..
85- li(_[[As soon as you have enough soldiers, attack and completely destroy the Barbarian buildings.]]) ..
86- li(_[[Finally, build up a fortress on the peninsula (near where the Barbarian headquarters stood before), to avoid new settlements of other tribes in that region.]])
87+ li(_[[Attack and completely destroy the Barbarian buildings as soon as you have enough soldiers.]]) ..
88+ li(_[[Build a fortress on the peninsula (near where the Barbarian headquarters stood before). Finally, this will avoid new settlements of other tribes in that region.]])
89 ),
90 }
91
92@@ -212,7 +214,7 @@
93 _([[Lutius, don’t you think you forgot something important?]])
94 .. paragraphdivider() ..
95 -- TRANSLATORS: Amalea
96- _([[It’s nice, and of course a good idea, to build up mines, which will give us a more comfortable life, but the people working in the mines are unhappy with the current situation. They have to do hard work and have no time for making their own food.]])
97+ _([[It’s nice, and of course a good idea, to build mines, which will give us a more comfortable life, but the people working in the mines are unhappy with the current situation. They have to do hard work and have no time for making their own food.]])
98 .. paragraphdivider() ..
99 -- TRANSLATORS: Amalea
100 _([[What do you think about helping them out? I can’t tell you what we need exactly… but here are my recommendations:]]))
101@@ -243,7 +245,7 @@
102 _([[At first, I was naive and hoped that they were peaceful, but as soon as one of them saw me, they charged towards me and started attacking me with their throwing spears. Thanks be to the Gods that I was able to flee and hide myself, before retreating back to our colony under cover of darkness.]])
103 .. paragraphdivider() ..
104 -- TRANSLATORS: Lutius - Diary
105- _([[Anyway, we must build up stronger military buildings as soon as possible.]]))
106+ _([[Anyway, we must build stronger military buildings as soon as possible.]]))
107 .. new_objectives(obj_build_bigger_military_buildings)
108 }
109

Subscribers

People subscribed via source and target branches

to status/vote changes: