Code review comment for lp:~widelands-dev/widelands/notifications_shipwindow

Revision history for this message
SirVer (sirver) wrote :

> I want to remove the dependency from logic to wui,

that is a noble and excellent goal!

> and I think the Notification system is a good way of doing that.

I designed it with this idea in mind - to decouple user interface from logic.

I think the big problem in this change is the tracking of the open ship windows - I'd try getting rid of that by subscribing again for each ship window.

review: Needs Fixing

« Back to merge proposal