Code review comment for lp:~widelands-dev/widelands/net-user-type

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

Sorry I was unable to the get wlms server going:

klaus$ ./go/bin/wlms
2018/05/01 10:07:50 No configuration found, using in-memory database
2018/05/01 10:07:50 Using 127.0.0.1 and fe80::1 as IP addresses of the relay
2018/05/01 10:07:50 Unable to connect to relay server at localhost: dial tcp [::1]:7398: connect: connection refused
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x13152c1]

goroutine 53 [running]:
main.(*Server).mainLoop(0xc4201480c0)
 /Users/klaus/go/src/github.com/widelands/widelands_metaserver/wlms/server.go:450 +0x41
created by main.CreateServerUsing
 /Users/klaus/go/src/github.com/widelands/widelands_metaserver/wlms/server.go:445 +0x5b0

And I was unbale to git checkout that pullrequerst, either. No time to really deep dive into that code yet.

Still the code change is ok for me. So how to we get this into the offical server now?

review: Approve (review, compile)

« Back to merge proposal