Code review comment for lp:~widelands-dev/widelands/net-relay

Revision history for this message
SirVer (sirver) wrote :

I am on business travel and therefore slow to respond.

> It is returning the player IDs as seen by the relay, which are something different than the player IDs in the GameHost/Client code.

I think these IDs should stay private to Widelands and the metaserver/relay respectively. Instead when they need to communicate about a particular player, they should send the player id as string - and map them internally to their ids.

Is this ready for another review round? What about the metaserver branch?

« Back to merge proposal