Code review comment for lp:~widelands-dev/widelands/net-relay

Revision history for this message
Notabilis (notabilis27) wrote :

1) Thanks, looks good. Not that I really understand this construct.

2) Okay. Seems to be worth looking into that, but not in this branch.

3) I added a simple protocol for this. Please see relay_protocol.h (diff line 1918ff) for the design, it should us allow what we want to do. Metaserver support is missing for it, when you approve of the design I will add it there, too. Adding the RTT-display-/kicking-GUI should be a Widelands-only change later on.

4) A still open NOCOM is regarding the move-constructor of RecvPacket. The problem is that this class extends the (old) class StreamRead, which removes the copy-constructor explicitly. We could remove this declaration but it is probably there for a reason. So I guess it is either move operations or ... no real idea.

« Back to merge proposal