Code review comment for lp:~widelands-dev/widelands/net-boost-asio

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

Codecheck from travis fails, but for some compilers?
grep '^[/_.a-zA-Z]\+:[0-9]\+:' codecheck.out

/home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:225: Use log() from base/log.h instead of printf.

/home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:238: Comments need to start with a space.

/home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:261: Old C-Style cast. Change to static_cast<Type>(var) or similar!

/home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:264: Use log() from base/log.h instead of printf.

/home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:271: Use log() from base/log.h instead of printf.

/home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:275: Comments need to start with a space.

/home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:280: Old C-Style cast. Change to static_cast<Type>(var) or similar!

/home/travis/build/widelands/widelands/src/network/network_lan_promotion.cc:283: Use log() from base/log.h instead of printf.

+echo 'You have codecheck warnings (see above) Please fix.'

You have codecheck warnings (see above) Please fix.

« Back to merge proposal