Merge lp:~widelands-dev/widelands/missing_worker_animations into lp:widelands

Proposed by kaputtnik
Status: Merged
Merge reported by: kaputtnik
Merged at revision: not available
Proposed branch: lp:~widelands-dev/widelands/missing_worker_animations
Merge into: lp:widelands
Diff against target: 120 lines (+13/-12)
5 files modified
tribes/workers/atlanteans/forester/init.lua (+2/-2)
tribes/workers/barbarians/ranger/init.lua (+2/-2)
tribes/workers/empire/fisher/init.lua (+2/-1)
tribes/workers/empire/forester/init.lua (+2/-2)
tribes/workers/empire/vinefarmer/init.lua (+5/-5)
To merge this branch: bzr merge lp:~widelands-dev/widelands/missing_worker_animations
Reviewer Review Type Date Requested Status
TiborB Approve
Review via email: mp+281365@code.launchpad.net

Description of the change

Correction to empire fisher animation and renaming of some other animations to have more consistence on the names.

To post a comment you must log in.
Revision history for this message
TiborB (tiborb95) wrote :

LGTM

review: Approve
Revision history for this message
TiborB (tiborb95) wrote :

Kaputtnik, will you push it into trunk?
I could do it, but there are some text conflicts in:

Text conflict in tribes/workers/atlanteans/forester/init.lua
Text conflict in tribes/workers/barbarians/ranger/init.lua
Text conflict in tribes/workers/empire/fisher/init.lua
Text conflict in tribes/workers/empire/forester/init.lua
Text conflict in tribes/workers/empire/vinefarmer/init.lua

Revision history for this message
kaputtnik (franku) wrote :

I think i didn't have the rights to merge with trunk...

I look into the conflicts. Thanks :-)

Revision history for this message
TiborB (tiborb95) wrote :

I am not sure if you can merge into trunk, but I can do it...

Just let me know (f.e. post a comment here)

Revision history for this message
GunChleoc (gunchleoc) wrote :

Everybody who is on widelands-dev can merge into trunk :)

Revision history for this message
kaputtnik (franku) wrote :

Resolved conflicts and pushed to trunk.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tribes/workers/atlanteans/forester/init.lua'
2--- tribes/workers/atlanteans/forester/init.lua 2015-11-05 12:53:49 +0000
3+++ tribes/workers/atlanteans/forester/init.lua 2015-12-26 19:43:23 +0000
4@@ -12,7 +12,7 @@
5 hotspot = { 5, 23 },
6 fps = 5
7 },
8- crop = {
9+ planting = {
10 template = "plant_??",
11 directory = dirname,
12 hotspot = { 17, 21 },
13@@ -48,7 +48,7 @@
14 "findspace size:any radius:5 avoid:field",
15 "walk coords",
16 "animation dig 2000", -- Play a planting animation
17- "animation crop 1000", -- Play a planting animation
18+ "animation planting 1000", -- Play a planting animation
19 "plant attrib:tree_sapling",
20 "animation water 2000",
21 "return"
22
23=== modified file 'tribes/workers/barbarians/ranger/init.lua'
24--- tribes/workers/barbarians/ranger/init.lua 2015-11-05 12:53:49 +0000
25+++ tribes/workers/barbarians/ranger/init.lua 2015-12-26 19:43:23 +0000
26@@ -12,7 +12,7 @@
27 hotspot = { 12, 24 },
28 fps = 5
29 },
30- crop = {
31+ planting = {
32 template = "plant_??",
33 directory = dirname,
34 hotspot = { 18, 24 },
35@@ -48,7 +48,7 @@
36 "findspace size:any radius:5 avoid:field",
37 "walk coords",
38 "animation dig 2000",
39- "animation crop 1000",
40+ "animation planting 1000",
41 "plant attrib:tree_sapling",
42 "animation water 2000",
43 "return"
44
45=== modified file 'tribes/workers/empire/fisher/init.lua'
46--- tribes/workers/empire/fisher/init.lua 2015-11-05 12:53:49 +0000
47+++ tribes/workers/empire/fisher/init.lua 2015-12-26 19:43:23 +0000
48@@ -7,9 +7,10 @@
49 hotspot = { 7, 38 },
50 },
51 fishing = {
52- template = "idle_??",
53+ template = "fishing_??",
54 directory = dirname,
55 hotspot = { 9, 39 },
56+ fps = 10,
57 }
58 }
59 add_worker_animations(animations, "walk", dirname, "walk", {10, 38}, 20)
60
61=== modified file 'tribes/workers/empire/forester/init.lua'
62--- tribes/workers/empire/forester/init.lua 2015-11-05 12:53:49 +0000
63+++ tribes/workers/empire/forester/init.lua 2015-12-26 19:43:23 +0000
64@@ -12,7 +12,7 @@
65 hotspot = { 5, 22 },
66 fps = 5
67 },
68- crop = {
69+ planting = {
70 template = "plant_??",
71 directory = dirname,
72 hotspot = { 18, 23 },
73@@ -48,7 +48,7 @@
74 "findspace size:any radius:5 avoid:field",
75 "walk coords",
76 "animation dig 2000",
77- "animation crop 1000",
78+ "animation planting 1000",
79 "plant attrib:tree_sapling",
80 "animation water 2000",
81 "return"
82
83=== modified file 'tribes/workers/empire/vinefarmer/init.lua'
84--- tribes/workers/empire/vinefarmer/init.lua 2015-11-05 12:53:49 +0000
85+++ tribes/workers/empire/vinefarmer/init.lua 2015-12-26 19:43:23 +0000
86@@ -12,13 +12,13 @@
87 hotspot = { 8, 24 },
88 fps = 10
89 },
90- plant = {
91+ planting = {
92 template = "plant_??",
93 directory = dirname,
94 hotspot = { 15, 23 },
95 fps = 10
96 },
97- gather = {
98+ gathering = {
99 template = "gather_??",
100 directory = dirname,
101 hotspot = { 9, 22 },
102@@ -50,15 +50,15 @@
103 "walk coords",
104 "animation dig 2000",
105 "plant tribe:grapevine_tiny",
106- "animation plant 3000",
107+ "animation planting 3000",
108 "return"
109 },
110 harvestvine = {
111 "findobject attrib:ripe_grapes radius:1",
112 "walk object",
113- "animation gather 10000",
114+ "animation gathering 10000",
115 "object harvest",
116- "animation gather 2000",
117+ "animation gathering 2000",
118 "createware grape",
119 "return"
120 }

Subscribers

People subscribed via source and target branches

to status/vote changes: