Code review comment for lp:~widelands-dev/widelands/mipmaps

Revision history for this message
Benedikt Straub (nordfriese) wrote :

Did you forget to add the mipmaps for some of your testcases? I can find them only for the BAR warehouse idle, BAR shipyard working and BAR recruit walk_*; not for the builder, shipwright, ponds and bushes ..?
And I get a crash sometimes because the small blueberry has unmatching image sizes.

The warehouse and shipyard look very different when zooming in than on normal scale, but I assume that that´s an error in the settings with which they were re-rendered in Blender, and not a bug in the branch.
I don´t see any difference between the "old" scaling algorithm and the new mipmap when zooming out though.

Will do a code review soonish…

Thanks for implementing this feature :)

« Back to merge proposal