Merge lp:~widelands-dev/widelands/irc_users into lp:widelands
Proposed by
Notabilis
Status: | Merged |
---|---|
Merged at revision: | 8570 |
Proposed branch: | lp:~widelands-dev/widelands/irc_users |
Merge into: | lp:widelands |
Diff against target: |
117 lines (+41/-16) 2 files modified
src/network/internet_gaming.cc (+31/-16) src/ui_fsmenu/internet_lobby.cc (+10/-0) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands/irc_users |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
GunChleoc | Approve | ||
Review via email: mp+335898@code.launchpad.net |
Commit message
Sorting IRC users behind the players in the lobby.
Description of the change
When the next version of the metaserver is deployed [1], IRC users will also be listed in the lobby as players with a build-id of "IRC". Currently, this leads to a long list of IRC users followed by a few entries of players.
With this branch, IRC users are listed after the online players. Additionally, no "user status" (unregistered, ...) is displayed for them.
[1] https:/
To post a comment you must log in.
Additionally, I wanted to color the lines of the IRC users in gray. However, this did not work. EntryRecord: :set_color( ) method seems to be broken. At least, it does nothing and I can't find code that reads the set color.
- A <rt><font ...> directive was printed as text.
- The existing Table::
I wouldn't mind leaving it as it is, though. Without the status symbols the lines stand out enough in my opinion.
When logging in to the metaserver, the user is greeted by the (obsolete) message "For hosting a game, ...". Maybe add a similar message "Users on IRC are unlikely to react to chat messages"? I think in the past we had some users on the forum which complained about not getting any answers.