Code review comment for lp:~widelands-dev/widelands/handle_tab

Revision history for this message
Shevonar (shevonar) wrote :

I just noticed a little misinterpretation: case SDLK_KP_ENTER is actually not an empty switch case. It just falls through to case SDLK_RETURN to handle the Enter key on the keypad the same way as the Return key. A case is only redundant if it falls through to the default case. Even a case foo: break; might be useful as it prevents the default case from execution.

review: Needs Fixing

« Back to merge proposal