Merge lp:~widelands-dev/widelands/fix_resolution_change_mouse_bug into lp:widelands

Proposed by SirVer
Status: Merged
Merged at revision: 8456
Proposed branch: lp:~widelands-dev/widelands/fix_resolution_change_mouse_bug
Merge into: lp:widelands
Diff against target: 11 lines (+1/-0)
1 file modified
src/wui/interactive_base.cc (+1/-0)
To merge this branch: bzr merge lp:~widelands-dev/widelands/fix_resolution_change_mouse_bug
Reviewer Review Type Date Requested Status
GunChleoc Approve
kaputtnik (community) testing Approve
Review via email: mp+330888@code.launchpad.net

Commit message

Resize MapView if resolution changes.

To post a comment you must log in.
Revision history for this message
kaputtnik (franku) wrote :

The bug is fixed :-)

review: Approve (testing)
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 2676. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/276586857.
Appveyor build 2497. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_resolution_change_mouse_bug-2497.

Revision history for this message
SirVer (sirver) wrote :

Thanks. There is not much code to review, so I'm gonna merge.

@bunnybot merge

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 2676. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/276586857.
Appveyor build 2497. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_resolution_change_mouse_bug-2497.

Revision history for this message
GunChleoc (gunchleoc) wrote :

LTGM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/wui/interactive_base.cc'
2--- src/wui/interactive_base.cc 2017-09-15 19:18:08 +0000
3+++ src/wui/interactive_base.cc 2017-09-17 18:20:50 +0000
4@@ -151,6 +151,7 @@
5 graphic_resolution_changed_subscriber_ = Notifications::subscribe<GraphicResolutionChanged>(
6 [this](const GraphicResolutionChanged& message) {
7 set_size(message.width, message.height);
8+ map_view_.set_size(message.width, message.height);
9 resize_chat_overlay();
10 adjust_toolbar_position();
11 });

Subscribers

People subscribed via source and target branches

to status/vote changes: