Code review comment for lp:~widelands-dev/widelands/fix_overlays
Revision history for this message
| xxx-deleted (janosch-peters-deactivatedaccount) wrote | # |
review:
Approve
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Tho code look good, sorry for introducing this bug.
About the resource-editing thing: Strictly speaking I think the behaviour is consistent.
The analogous feature of "remove immovable" in terms of resources is "set resource to 0". This works even if you have a different resource selected. The decrease/increase resource has no equivalent.
After a little bit of testing I also think the current increase/decrease behaviour makes sense. Imaging you have several resource sitting next to another. If you have a bigger tool size and start to reduce resources, it should only affect the resource you have selected. If we change the behaviour to allow decreasing any resource, at least in my scenario this will lead to unexpected results.