Code review comment for lp:~widelands-dev/widelands/fix_infrastructure_return_values

Revision history for this message
kaputtnik (franku) wrote :

Klaus, this code is only used in scenarios or campaigns.

I grep'd through the data directory and currently all campaigns which use prefilled_buildings() or place_building_in_region() didn't use any return values. I would have been surprised if they do :-D

The branch linked in bug 1639514 uses the return value from prefilled_buildings():

https://bazaar.launchpad.net/~widelands-dev/widelands/bug-1639514_fix_yellow_player/view/head:/data/campaigns/bar02.wmf/scripting/starting_conditions.lua#L97

For testing one has to write a scenario map. I could do so if it is wanted :-)

« Back to merge proposal