Merge lp:~widelands-dev/widelands/fix-wl_include_system_directories into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 9052
Proposed branch: lp:~widelands-dev/widelands/fix-wl_include_system_directories
Merge into: lp:widelands
Diff against target: 47 lines (+5/-3)
3 files modified
appveyor.yml (+2/-0)
cmake/WlFunctions.cmake (+1/-1)
utils/win32/innosetup/Widelands.iss (+2/-2)
To merge this branch: bzr merge lp:~widelands-dev/widelands/fix-wl_include_system_directories
Reviewer Review Type Date Requested Status
Widelands Developers Pending
Review via email: mp+366266@code.launchpad.net

Commit message

Downgrade Boost on AppVeyor, because CMake can't find version 1.70 yet. Upgrade InnoSetup to ICU version 64.

Description of the change

AppVeyor is in a huff again. Let's see if this will fix it.

To post a comment you must log in.
9053. By GunChleoc

Downgrade Boost on AppVeyor to version 1.69.0-1

9054. By GunChleoc

Try boost-1.69.0-2.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4731. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/521836139.
Appveyor build 4516. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_wl_include_system_directories-4516.

9055. By GunChleoc

Try libicuuc63.dll

9056. By GunChleoc

Try ICU version 64

9057. By GunChleoc

libicudt64.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Appveyor is going green now.

@bunnybot merge

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 4735. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/522061797.
Appveyor build 4520. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_wl_include_system_directories-4520.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'appveyor.yml'
2--- appveyor.yml 2019-02-15 20:04:29 +0000
3+++ appveyor.yml 2019-04-19 07:39:14 +0000
4@@ -23,6 +23,8 @@
5 # Installed required libs
6 - cmd: "bash --login -c \"pacman --noconfirm -S mingw-w64-%MINGWSUFFIX%-ninja mingw-w64-%MINGWSUFFIX%-boost mingw-w64-%MINGWSUFFIX%-SDL2_ttf mingw-w64-%MINGWSUFFIX%-SDL2_mixer mingw-w64-%MINGWSUFFIX%-SDL2_image\""
7 - cmd: "IF \"%PLATFORM%\" == \"x86\" (bash --login -c \"pacman --noconfirm -S mingw-w64-%MINGWSUFFIX%-glew\") ELSE (bash --login -c \"pacman --noconfirm -S mingw-w64-%MINGWSUFFIX%-glbinding\")"
8+ # CMake can't find Boost 1.70 yet, so we have to downgrade
9+ - cmd: "bash --login -c \"wget http://repo.msys2.org/mingw/%MINGWSUFFIX%/mingw-w64-%MINGWSUFFIX%-boost-1.69.0-2-any.pkg.tar.xz && pacman --noconfirm -U mingw-w64-%MINGWSUFFIX%-boost-1.69.0-2-any.pkg.tar.xz\""
10
11 shallow_clone: true
12
13
14=== modified file 'cmake/WlFunctions.cmake'
15--- cmake/WlFunctions.cmake 2017-05-14 21:06:23 +0000
16+++ cmake/WlFunctions.cmake 2019-04-19 07:39:14 +0000
17@@ -40,7 +40,7 @@
18 # it works is different. SYSTEM includes silence warnings for included headers etc.
19 function(wl_include_system_directories TARGET DIR)
20 _include_directories_internal(${TARGET} ${DIR} TRUE)
21-endfunction(wl_include_system_directories TARGET_DIR)
22+endfunction(wl_include_system_directories TARGET DIR)
23
24 # Add common compile tasks, like includes and libraries to link against for third party
25 # libraries, and codecheck hook for sources.
26
27=== modified file 'utils/win32/innosetup/Widelands.iss'
28--- utils/win32/innosetup/Widelands.iss 2019-03-13 13:48:08 +0000
29+++ utils/win32/innosetup/Widelands.iss 2019-04-19 07:39:14 +0000
30@@ -106,7 +106,7 @@
31 Source: {#DLLFolder}\libtermcap-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
32 Source: {#DLLFolder}\libgmodule-2.0-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
33 Source: {#DLLFolder}\libreadline8.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
34-Source: {#DLLFolder}\libicuuc62.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
35+Source: {#DLLFolder}\libicuuc64.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
36 Source: {#DLLFolder}\libbz2-1.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
37 Source: {#DLLFolder}\libfreetype-6.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
38 #if GetEnv("PLATFORM") == "x64"
39@@ -118,7 +118,7 @@
40 #endif
41 Source: {#DLLFolder}\libglib-2.0-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
42 Source: {#DLLFolder}\libharfbuzz-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
43-Source: {#DLLFolder}\libicudt62.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
44+Source: {#DLLFolder}\libicudt64.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
45 Source: {#DLLFolder}\libjpeg-8.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
46 Source: {#DLLFolder}\liblzma-5.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"
47 Source: {#DLLFolder}\libogg-0.dll; DestDir: {app}; Flags: ignoreversion; Components: "Widelands"

Subscribers

People subscribed via source and target branches

to status/vote changes: