Merge lp:~widelands-dev/widelands/fix-strings into lp:widelands

Proposed by Hans Joachim Desserud
Status: Merged
Approved by: GunChleoc
Approved revision: no longer in the source branch.
Merged at revision: 6870
Proposed branch: lp:~widelands-dev/widelands/fix-strings
Merge into: lp:widelands
Diff against target: 194 lines (+39/-39)
8 files modified
src/editor/editorinteractive.cc (+1/-1)
src/editor/ui_menus/editor_main_menu_save_map.cc (+3/-3)
src/ui_fsmenu/singleplayer.cc (+1/-1)
src/wui/game_chat_menu.cc (+1/-1)
src/wui/game_main_menu_save_game.cc (+3/-3)
src/wui/game_message_menu.cc (+3/-3)
src/wui/game_objectives_menu.cc (+1/-1)
txts/editor_readme (+26/-26)
To merge this branch: bzr merge lp:~widelands-dev/widelands/fix-strings
Reviewer Review Type Date Requested Status
SirVer Approve
GunChleoc Pending
Review via email: mp+210465@code.launchpad.net

Description of the change

Various stringfixes, and tweaking a couple of strings so the same translation can be applied in multiple places.

(Just marked these while going through untranslated strings)

To post a comment you must log in.
Revision history for this message
SirVer (sirver) wrote :

Looks good to me, but GunChleoc is mistress of strings imho.

review: Approve
Revision history for this message
GunChleoc (gunchleoc) wrote :

Yes, I think this looks fine. It would be great to have the kayboad shortcuts as a table, but that would take some programming. Let's merge it like it is for now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/editor/editorinteractive.cc'
2--- src/editor/editorinteractive.cc 2014-03-09 18:32:29 +0000
3+++ src/editor/editorinteractive.cc 2014-03-11 17:59:00 +0000
4@@ -250,7 +250,7 @@
5 UI::WLMessageBox mmb
6 (this,
7 _("Unsaved Map"),
8- _("The Map has not been saved, do you really want to quit?"),
9+ _("The map has not been saved, do you really want to quit?"),
10 UI::WLMessageBox::YESNO);
11 if (mmb.run() == 0)
12 return;
13
14=== modified file 'src/editor/ui_menus/editor_main_menu_save_map.cc'
15--- src/editor/ui_menus/editor_main_menu_save_map.cc 2014-03-09 21:33:54 +0000
16+++ src/editor/ui_menus/editor_main_menu_save_map.cc 2014-03-11 17:59:00 +0000
17@@ -384,10 +384,10 @@
18 // Check if file exists. If so, show a warning.
19 if (g_fs->FileExists(complete_filename)) {
20 std::string s =
21- (boost::format(_("A File with the name ‘%s’ already exists. Overwrite?"))
22+ (boost::format(_("A file with the name ‘%s’ already exists. Overwrite?"))
23 % FileSystem::FS_Filename(filename.c_str())).str();
24 UI::WLMessageBox mbox
25- (&eia(), _("Error Saving Map!!"), s, UI::WLMessageBox::YESNO);
26+ (&eia(), _("Error Saving Map!"), s, UI::WLMessageBox::YESNO);
27 if (not mbox.run())
28 return false;
29
30@@ -407,7 +407,7 @@
31 "given:\n");
32 s += e.what();
33 UI::WLMessageBox mbox
34- (&eia(), _("Error Saving Map!!"), s, UI::WLMessageBox::OK);
35+ (&eia(), _("Error Saving Map!"), s, UI::WLMessageBox::OK);
36 mbox.run();
37 }
38 die();
39
40=== modified file 'src/ui_fsmenu/singleplayer.cc'
41--- src/ui_fsmenu/singleplayer.cc 2013-07-26 20:19:36 +0000
42+++ src/ui_fsmenu/singleplayer.cc 2014-03-11 17:59:00 +0000
43@@ -37,7 +37,7 @@
44 title
45 (this,
46 get_w() / 2, get_h() * 3 / 40,
47- _("Single Player Menu"), UI::Align_HCenter),
48+ _("Single Player"), UI::Align_HCenter),
49
50 // Buttons
51 new_game
52
53=== modified file 'src/wui/game_chat_menu.cc'
54--- src/wui/game_chat_menu.cc 2013-07-26 20:19:36 +0000
55+++ src/wui/game_chat_menu.cc 2014-03-11 17:59:00 +0000
56@@ -34,7 +34,7 @@
57 UI::UniqueWindow::Registry & registry,
58 ChatProvider & chat)
59 :
60-UI::UniqueWindow(parent, "chat", &registry, 440, 235, _("Chat Menu")),
61+UI::UniqueWindow(parent, "chat", &registry, 440, 235, _("Chat")),
62 m_chat(this, 5, 5, get_inner_w() - 10, get_inner_h() - 10, chat)
63 {
64 if (get_usedefaultpos())
65
66=== modified file 'src/wui/game_main_menu_save_game.cc'
67--- src/wui/game_main_menu_save_game.cc 2014-03-09 21:33:54 +0000
68+++ src/wui/game_main_menu_save_game.cc 2014-03-11 17:59:00 +0000
69@@ -252,7 +252,7 @@
70 "Reason given:\n");
71 s += error;
72 UI::WLMessageBox mbox
73- (&igbase, _("Save Game Error!!"), s, UI::WLMessageBox::OK);
74+ (&igbase, _("Save Game Error!"), s, UI::WLMessageBox::OK);
75 mbox.run();
76 }
77 game.save_handler().set_current_filename(complete_filename);
78@@ -264,8 +264,8 @@
79 :
80 UI::WLMessageBox
81 (&parent,
82- _("Save Game Error!!"),
83- (boost::format(_("A File with the name ‘%s’ already exists. Overwrite?"))
84+ _("Save Game Error!"),
85+ (boost::format(_("A file with the name ‘%s’ already exists. Overwrite?"))
86 % FileSystem::FS_Filename(filename.c_str())).str(),
87 YESNO),
88 m_filename(filename)
89
90=== modified file 'src/wui/game_message_menu.cc'
91--- src/wui/game_message_menu.cc 2014-03-03 20:50:30 +0000
92+++ src/wui/game_message_menu.cc 2014-03-11 17:59:00 +0000
93@@ -43,7 +43,7 @@
94 (Interactive_Player & plr, UI::UniqueWindow::Registry & registry)
95 :
96 UI::UniqueWindow
97- (&plr, "messages", &registry, 580, 375, _("Message Menu: Inbox")),
98+ (&plr, "messages", &registry, 580, 375, _("Messages: Inbox")),
99 message_body
100 (this,
101 5, 150, 570, 220,
102@@ -363,14 +363,14 @@
103 switch (mode) {
104 case Inbox:
105 mode = Archive;
106- set_title(_("Message Menu: Archive"));
107+ set_title(_("Messages: Archive"));
108 m_archivebtn->set_pic(g_gr->images().get("pics/message_restore.png"));
109 m_archivebtn->set_tooltip(_("Restore selected messages"));
110 m_togglemodebtn->set_title(_("Show Inbox"));
111 break;
112 case Archive:
113 mode = Inbox;
114- set_title(_("Message Menu: Inbox"));
115+ set_title(_("Messages: Inbox"));
116 m_archivebtn->set_pic(g_gr->images().get("pics/message_archive.png"));
117 m_archivebtn->set_tooltip(_("Archive selected messages"));
118 m_togglemodebtn->set_title(_("Show Archive"));
119
120=== modified file 'src/wui/game_objectives_menu.cc'
121--- src/wui/game_objectives_menu.cc 2013-07-26 20:19:36 +0000
122+++ src/wui/game_objectives_menu.cc 2014-03-11 17:59:00 +0000
123@@ -41,7 +41,7 @@
124 (&plr, "objectives", &registry,
125 340,
126 5 + OBJECTIVE_LIST + 5 + FULL_OBJECTIVE_TEXT + 5 + BUTTON_HEIGHT + 5,
127- _("Objectives Menu")),
128+ _("Objectives")),
129 list
130 (this,
131 5, 5,
132
133=== modified file 'txts/editor_readme'
134--- txts/editor_readme 2014-02-24 17:11:25 +0000
135+++ txts/editor_readme 2014-03-11 17:59:00 +0000
136@@ -18,32 +18,32 @@
137 _"Keyboard shortcuts"
138 "</p>"
139 "<p line-spacing=3 font-size=12><br>"
140-_"SPACE Toggles if building spaces are shown"
141-"<br>"
142-_"C Toggles census on/off"
143-"<br>"
144-_"E Toggles event menu"
145-"<br>"
146-_"F Toggles fullscreen"
147-"<br>"
148-_"H Toggles main menu"
149-"<br>"
150-_"M Toggles minimap"
151-"<br>"
152-_"P Toggles player menu"
153-"<br>"
154-_"T Toggles tools menu"
155-"<br>"
156-_"I Activates information tool"
157-"<br>"
158-_"CTRL+L Load Map"
159-"<br>"
160-_"CTRL+S Save Map"
161+_"SPACE: toggles if building spaces are shown"
162+"<br>"
163+_"C: toggles census"
164+"<br>"
165+_"E: toggles event menu"
166+"<br>"
167+_"F: toggles fullscreen"
168+"<br>"
169+_"H: toggles main menu"
170+"<br>"
171+_"M: toggles minimap"
172+"<br>"
173+_"P: toggles player menu"
174+"<br>"
175+_"T: toggles tools menu"
176+"<br>"
177+_"I: activates information tool"
178+"<br>"
179+_"CTRL+L: load Map"
180+"<br>"
181+_"CTRL+S: save Map"
182 "<br><br>"
183-_"1-0 Changes tool size"
184-"<br>"
185-_"SHIFT (Hold) Selects first alternative tool while pressed"
186-"<br>"
187-_"ALT (Hold) Selects second alternative tool while pressed"
188+_"1-0: changes tool size"
189+"<br>"
190+_"SHIFT (Hold): selects first alternative tool while pressed"
191+"<br>"
192+_"ALT (Hold): Selects second alternative tool while pressed"
193 "<br>"
194 "</p></rt>""

Subscribers

People subscribed via source and target branches

to status/vote changes: