Merge lp:~widelands-dev/widelands/fix-random-tribe into lp:widelands

[Shevonar]

Proper seeding of std::rand function before selecting random tribe. I am not sure if the time function is available on Windows like this, therefore I would like Tino to test this before merging. Thanks :)

[SirVer (sirver)]

A nit:
- Pull the srand initialization into wlapplication (i.e. our 'main' function equivalent) and only do it once. Should we ever want to inject a seed (for testing) it should only be done in one place and this should have the same effect in all your call sites.

review: Needs Fixing

[Tino (tino79)]

Does compile fine on windows and as far as i can see (small sample size), the distribution of tribes is random.

review: Approve

[Shevonar (shevonar)]

Thanks for your feedback SirVer, I changed it.
Thanks you Tino for testing on Windows.

I'll merge this now.

=== modified file 'src/wlapplication.cc'
--- src/wlapplication.cc	2014-03-29 16:04:47 +0000
+++ src/wlapplication.cc	2014-04-07 20:47:36 +0000
@@ -304,6 +304,9 @@
 	if (SDLNet_Init() == -1)
 		throw wexception("SDLNet_Init failed: %s\n", SDLNet_GetError());
 
+	// seed random number generator used for random tribe selection
+	std::srand(time(nullptr));
+
 	//make sure we didn't forget to read any global option
 	g_options.check_used();
 }