Merge lp:~widelands-dev/widelands/find_portdock_reworked into lp:widelands
Proposed by
TiborB
Status: | Merged |
---|---|
Merged at revision: | 7845 |
Proposed branch: | lp:~widelands-dev/widelands/find_portdock_reworked |
Merge into: | lp:widelands |
Diff against target: |
66 lines (+31/-23) 1 file modified
src/logic/map.cc (+31/-23) |
To merge this branch: | bzr merge lp:~widelands-dev/widelands/find_portdock_reworked |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
GunChleoc | Approve | ||
Review via email: mp+286408@code.launchpad.net |
Description of the change
This needs a discussion. Generally it works good enough, but I dont fully understand old logic. The code:
- returns portdock of size up to 2 (fields)
- makes sure all fields are valid
- but the problem (not invoked by this change) is when function returns 0 fields of portdock. The calling code is not ready for portdock of size 0. It crashes the game.
During my testing I had not run into such situation though...
To post a comment you must log in.
Continuous integration builds have changed state:
Travis build 727. State: passed. Details: https:/ /travis- ci.org/ widelands/ widelands/ builds/ 109980041. /ci.appveyor. com/project/ widelands- dev/widelands/ build/_ widelands_ dev_widelands_ find_portdock_ reworked- 574.
Appveyor build 574. State: success. Details: https:/