Code review comment for lp:~widelands-dev/widelands/fh1

Revision history for this message
cghislai (charlyghislain) wrote :

Sirver, can you take a look at text_layout.h? I defined it as a read-only interface, along with an implementation that allows adding nodes info. I am not sure how/where to define that implementation. It is only used in the fonthandler(which downcast and reset it) and rt_render.

Also, I removed custom font attributes, and linked font and horizontal align to the locale used. I also set an option to scale fonts to screen resolution.

- Is that font scale option needed? All text areas will have to specify their height in order to get correctly aligned if fonts are not scaled at higher resolution
- Concerning MultilineTextarea, in your branch you expected richtext, while here simple text is allowed and formatted as_ui_font, is that ok?

Happy vacation :)

« Back to merge proposal