Code review comment for lp:~widelands-dev/widelands/fh1

Revision history for this message
cghislai (charlyghislain) wrote :

I will try to tidy the patch.

As we should first converge the API in graphics/ and text_layout.h, maybe you should have a look there in the first place. From what I see, your text_layout looks more appealing. I think we should merge yours into this one and update text_layout and text_area.

This patch is big, but changes to all ui elements was required. I would also like to unify all signals/getters/setters of basic elements

There are still some important changes that needs to be done here, with respect to the previous comments. That is linking font to locale, (re)introducing bold/italic and serif/condensed styles attributes and removing face attribute.

My branch is about removing the legacy richtext renderer and using the new one everywhere (especially in editboxes), so we should find some common grounds :). In particular, I introduced LayoutInfo to expose text nodes position and updated the rt_renderer to allow keeping extra spaces.

« Back to merge proposal