Code review comment for lp:~widelands-dev/widelands/fh1

Revision history for this message
Nasenbaer (nasenbaer) wrote :

Seems that this is a matter of taste - I completely (like 100%) agree with you, however as far as I remember, SirVer does not (e.g. take a look at #1 of https://bugs.launchpad.net/widelands/+bug/1184185 )

For me it seems much better to have a simple option, and everything is working based upon that setting but working way than to to

concerning:
> However, as I understood from reading some bug reports, custom font support were implemented so that users using exotic locales could find a font that render text correctly. It might not be easy to switch serif/sans in those cases, except if we allow custom serif and custom sans font.

I see no problem here - if I write a text and decide to make it "more beautiful" by using a mixture of sans and serif, this decission is of course based upon Latin characters. So if e.g. someone reading the translated text in arabic and sets both styles - serif and sans - to the same TTF font, there is no problem with it (to be more specific: it isn't even a problem if someone is doing this in the untranslated version). Of course this sounds like "more clutter options", but we can still add it to the advanced options menu, as the font selection is at the moment + (and that's the major PLUS for me) We would be simply able to use serif and sans styles without having to worry about which ttf will actually be used. -> and after all that system will be much easier to maintain if for some reason the default font will be changed or removed at some point.

« Back to merge proposal