Code review comment for lp:~widelands-dev/widelands/fh1-winconditions

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

I played this some time now and got an ugly crash, here:

Cmd_EnemyFlagAction::execute player(3): flag->owner(4) number=4
Assertion failed: (it != entries_.end()), function drop, file /Users/klaus/develop/widelands-repo/fh1-winconditions/src/graphic/texture_cache.cc, line 79.

3 libsystem_c.dylib 0x00007fffb52b3893 __assert_rtn + 320
4 widelands 0x000000010f9d6bad TextureCache::drop() + 845 (texture_cache.cc:79)
5 widelands 0x000000010f9d6121 TextureCache::insert(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::unique_ptr<Texture, std::__1::default_delete<Texture> >) + 801 (texture_cache.cc:63)
6 widelands 0x000000010f3b6aac RT::SdlTtfFont::render(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, RGBColor const&, int, TextureCache*) + 3932 (sdl_ttf_font.cc:131)
7 widelands 0x000000010f393ac5 RT::TextNode::render(TextureCache*) + 85 (rt_render.cc:521)
8 widelands 0x000000010f3a2764 RT::DivTagRenderNode::render(TextureCache*) + 3012 (rt_render.cc:746)
9 widelands 0x000000010f39bfeb RT::Renderer::render(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned short, std::__1::set<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) + 315 (rt_render.cc:1487)
10 widelands 0x000000010f2b6876 (anonymous namespace)::RTImage::texture() const + 262 (font_handler1.cc:92)
11 widelands 0x000000010f2b6685 (anonymous namespace)::RTImage::width() const + 21 (font_handler1.cc:75)
12 widelands 0x000000010f2b3612 UI::FontHandler1::render(std::__1::basic_string<char, std::__1::char_traits<char>,

Maybe this is again the memory problem we face on trunk, no idea, mmh

« Back to merge proposal