Merge lp:~widelands-dev/widelands/fh1-barbarians2 into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 8578
Proposed branch: lp:~widelands-dev/widelands/fh1-barbarians2
Merge into: lp:widelands
Diff against target: 175 lines (+33/-37)
1 file modified
data/campaigns/bar02.wmf/scripting/texts.lua (+33/-37)
To merge this branch: bzr merge lp:~widelands-dev/widelands/fh1-barbarians2
Reviewer Review Type Date Requested Status
Klaus Halfmann review, compile, testplay Approve
Review via email: mp+336707@code.launchpad.net

Commit message

Converted Barbarians Scenario 2 to new font renderer.

To post a comment you must log in.
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 3098. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/333839919.
Appveyor build 2905. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fh1_barbarians2-2905.

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

OK, see only obvious changes.

going to compile and testplay now

Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

Took me some time to play this to the very End,
but now its done.

Gun: you know that the Building help is all garbelde HTML, do you?

all else fine.

@bunnybot merge.

review: Approve (review, compile, testplay)
Revision history for this message
kaputtnik (franku) wrote :

> Gun: you know that the Building help is all garbelde HTML, do you?

Yes thats a known bug 1744583 I look into it...

Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for testing :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/campaigns/bar02.wmf/scripting/texts.lua'
2--- data/campaigns/bar02.wmf/scripting/texts.lua 2017-07-09 08:19:45 +0000
3+++ data/campaigns/bar02.wmf/scripting/texts.lua 2018-01-26 17:06:13 +0000
4@@ -1,5 +1,4 @@
5-include "scripting/formatting.lua"
6-include "scripting/format_scenario.lua"
7+include "scripting/richtext_scenarios.lua"
8
9 function thron(title, text)
10 return speech("map:chieftain.png", "2F9131", title, text)
11@@ -21,14 +20,13 @@
12 title = _"Build up a basic economy",
13 number = 5,
14 body = objective_text(_"Build up a basic economy",
15- _"Start collecting basic building materials, and fortify the camp."
16- .. paragraphdivider() ..
17- listitem_bullet(_"Build a lumberjack’s hut") ..
18- listitem_bullet(_"Build a ranger’s hut") ..
19- listitem_bullet(_"Build a quarry") ..
20- listitem_bullet(_"Build a wood hardener") ..
21- listitem_bullet(_"Build a sentry on the eastern border") ..
22- listitem_arrow(_"You should eventually also build a reed yard and a lime kiln."))
23+ p(_"Start collecting basic building materials, and fortify the camp.") ..
24+ li(_"Build a lumberjack’s hut") ..
25+ li(_"Build a ranger’s hut") ..
26+ li(_"Build a quarry") ..
27+ li(_"Build a wood hardener") ..
28+ li(_"Build a sentry on the eastern border") ..
29+ li_arrow(_"You should eventually also build a reed yard and a lime kiln."))
30 }
31
32 obj_build_small_food_economy = {
33@@ -36,13 +34,12 @@
34 title = _"Build up a small food economy",
35 number = 5,
36 body = objective_text(_"Build up a small food economy",
37- _"Build up a basic food economy to provide your people with food."
38- .. paragraphdivider() ..
39- listitem_bullet(_"Build a fisher’s hut") ..
40- listitem_bullet(_"Build a hunter’s hut") ..
41- listitem_bullet(_"Build a well") ..
42- listitem_bullet(_"Build a farm") ..
43- listitem_bullet(_"Build a bakery"))
44+ p(_"Build up a basic food economy to provide your people with food.") ..
45+ li(_"Build a fisher’s hut") ..
46+ li(_"Build a hunter’s hut") ..
47+ li(_"Build a well") ..
48+ li(_"Build a farm") ..
49+ li(_"Build a bakery"))
50 }
51
52 obj_build_cattlefarm = {
53@@ -50,9 +47,8 @@
54 title = _"Build a cattle farm",
55 number = 1,
56 body = objective_text(_"Remember to build a cattle farm",
57- _"As your roads grow longer and your economy bigger, you should make good use of your oxen to help transport wares more quickly."
58- .. paragraphdivider () ..
59- listitem_bullet(_"Remember to build a cattle farm")
60+ p(_"As your roads grow longer and your economy bigger, you should make good use of your oxen to help transport wares more quickly.") ..
61+ li(_"Remember to build a cattle farm")
62 ),
63 }
64
65@@ -61,7 +57,7 @@
66 title = _"Build a tower",
67 number = 1,
68 body = objective_text(_"Build a tower",
69- listitem_bullet(_"Build a tower at the north-east border of your territory to get greater visual range and to protect your people from sudden attacks by enemies."))
70+ li(_"Build a tower at the north-east border of your territory to get greater visual range and to protect your people from sudden attacks by enemies."))
71 }
72
73 obj_explore_further = {
74@@ -69,7 +65,7 @@
75 title = _"Explore further",
76 number = 1,
77 body = objective_text(_"Explore further",
78- listitem_bullet(_"Build more military buildings to explore the area around the headquarters and to ensure the safety of your people."))
79+ li(_"Build more military buildings to explore the area around the headquarters and to ensure the safety of your people."))
80 }
81
82 obj_build_mining_economy = {
83@@ -77,7 +73,7 @@
84 title = _"Build a mining infrastructure",
85 number = 6,
86 body = objective_text(_"Build a mining infrastructure",
87- listitem_bullet(_"Expand your territory to the mountains, send geologists to search for ore and coal and build a mining economy with mines, taverns, smelting works and metal workshop."))
88+ li(_"Expand your territory to the mountains, send geologists to search for ore and coal and build a mining economy with mines, taverns, smelting works and metal workshop."))
89 }
90
91 obj_build_a_fortress = {
92@@ -85,7 +81,7 @@
93 title = _"Build a fortress",
94 number = 1,
95 body = objective_text(_"Build a fortress",
96- listitem_bullet(_"Build a fortress to the east of the mountains."))
97+ li(_"Build a fortress to the east of the mountains."))
98 }
99
100 obj_build_training_infrastructure = {
101@@ -93,10 +89,10 @@
102 title = _"Build a training infrastructure",
103 number = 4,
104 body = objective_text(_"Build a training infrastructure",
105- listitem_bullet(_"Build a barracks to train some basic soldiers.") ..
106- listitem_bullet(_"Build a battle arena and a training camp to the west of the mountains.") ..
107- listitem_bullet(_"Enhance your metal workshop to an ax workshop in order to produce weapons, and build up a second metal workshop to ensure the production of tools. When the blacksmith reaches his next level (master blacksmith), you can even enhance the ax workshop to a war mill, which will produce additional weapons.") ..
108- listitem_bullet(_"Build a helm smithy to the west of the mountains to provide your soldiers with better armor."))
109+ li(_"Build a barracks to train some basic soldiers.") ..
110+ li(_"Build a battle arena and a training camp to the west of the mountains.") ..
111+ li(_"Enhance your metal workshop to an ax workshop in order to produce weapons, and build up a second metal workshop to ensure the production of tools. When the blacksmith reaches his next level (master blacksmith), you can even enhance the ax workshop to a war mill, which will produce additional weapons.") ..
112+ li(_"Build a helm smithy to the west of the mountains to provide your soldiers with better armor."))
113 }
114
115
116@@ -105,8 +101,8 @@
117 title = _"Build a warehouse",
118 number = 1,
119 body = objective_text(_"Build a warehouse",
120- listitem_bullet(_"Build a warehouse to the west of the mountains.") ..
121- listitem_arrow(_"Warehouses are similar to your headquarters, with the only difference that they aren’t defended by soldiers. It is often wise to build a warehouse when your territory is growing and the paths to your headquarters get longer and longer."))
122+ li(_"Build a warehouse to the west of the mountains.") ..
123+ li_arrow(_"Warehouses are similar to your headquarters, with the only difference that they aren’t defended by soldiers. It is often wise to build a warehouse when your territory is growing and the paths to your headquarters get longer and longer."))
124 }
125
126 obj_build_trainingssites = {
127@@ -114,8 +110,8 @@
128 title = _"Build training sites",
129 number = 2,
130 body = objective_text(_"Build training sites",
131- listitem_bullet(_"Build a barracks, a battle arena and a training camp to the west of the mountains.") ..
132- listitem_arrow(_"Barracks train basic soldiers while training sites like a training camp or a battle arena are used for training soldiers in their different attributes. These attributes are important in fights and the better a soldier is, the higher is the chance to win a fight."
133+ li(_"Build a barracks, a battle arena and a training camp to the west of the mountains.") ..
134+ li_arrow(_"Barracks train basic soldiers while training sites like a training camp or a battle arena are used for training soldiers in their different attributes. These attributes are important in fights and the better a soldier is, the higher is the chance to win a fight."
135 .. "<br>" ..
136 _"The attributes are: health, attack, defense and evade."))
137 }
138@@ -125,7 +121,7 @@
139 title = _"Build weapons production",
140 number = 3,
141 body = objective_text(_"Build weapons production",
142- listitem_bullet(_"Enhance your metal workshop to an ax workshop in order to produce weapons, and build up a second metal workshop to ensure the production of tools. When the blacksmith reaches his next level (master blacksmith), you can even enhance the ax workshop to a war mill, which will produce additional weapons."))
143+ li(_"Enhance your metal workshop to an ax workshop in order to produce weapons, and build up a second metal workshop to ensure the production of tools. When the blacksmith reaches his next level (master blacksmith), you can even enhance the ax workshop to a war mill, which will produce additional weapons."))
144 }
145
146 obj_build_a_helmsmithy = {
147@@ -133,7 +129,7 @@
148 title=_"Build a helm smithy",
149 number = 1,
150 body = objective_text(_"Build a helm smithy",
151- listitem_bullet(_"Build a helm smithy to the west of the mountains to provide your soldiers with better armor."))
152+ li(_"Build a helm smithy to the west of the mountains to provide your soldiers with better armor."))
153 }
154
155 obj_destroy_kalitaths_army = {
156@@ -141,8 +137,8 @@
157 title = _"Destroy Kalitath’s army",
158 number = 2,
159 body = objective_text(_"Destroy Kalitath’s army",
160- listitem_bullet(_"Destroy Kalitath’s army and expand your territory to the east.") ..
161- listitem_arrow(_"To attack an enemy, you must click on the door of an adversary’s military building. A menu will pop up allowing you to select the number of soldiers that should attack. When you are ready with setting the number, click on the cross (‘Start Attack’)."))
162+ li(_"Destroy Kalitath’s army and expand your territory to the east.") ..
163+ li_arrow(_"To attack an enemy, you must click on the door of an adversary’s military building. A menu will pop up allowing you to select the number of soldiers that should attack. When you are ready with setting the number, click on the cross (‘Start Attack’)."))
164 }
165
166 obj_military_assault_on_althunran = {
167@@ -150,7 +146,7 @@
168 title = _"Military assault on Al’thunran",
169 number = 1,
170 body = objective_text(_"Military assault on Al’thunran",
171- listitem_bullet(_"Destroy all forces of Thron’s two brothers to liberate the throne-circle."))
172+ li(_"Destroy all forces of Thron’s two brothers to liberate the throne-circle."))
173 }
174
175 -- =======================================================================

Subscribers

People subscribed via source and target branches

to status/vote changes: