Merge lp:~widelands-dev/widelands/enemysites_check_delay_used_before_initialized into lp:widelands

[Jukka Pakarinen]

DefaultAI::enemysites_check_delay_ variable is not initialized before it is used.
The fix in the branch fixes the bug 1734544.

[TiborB (tiborb95)]

As discussed in bug, this value is wait time between two checks, so I suggest bit higher starting value. 30 would be fine...

[Jukka Pakarinen (flegu)]

Ok, I change the value!

[GunChleoc (gunchleoc)]

Thanks, let's have it!

@bunnybot merge

review: Approve

[bunnybot (widelandsofficial)]

Continuous integration builds have changed state:

Travis build 2858. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/307569921.
Appveyor build 2668. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_enemysites_check_delay_used_before_initialized-2668.

=== modified file 'src/ai/defaultai.cc'
--- src/ai/defaultai.cc	2017-11-20 07:54:19 +0000
+++ src/ai/defaultai.cc	2017-11-26 17:51:16 +0000
@@ -106,6 +106,7 @@
      ts_in_const_count_(0),
      ts_without_trainers_(0),
      inhibit_road_building_(0),
+     enemysites_check_delay_(30),
      resource_necessity_water_needed_(false),
      highest_nonmil_prio_(0),
      seafaring_economy(false),