Code review comment for lp:~widelands-dev/widelands/economy-target-profiles

Also:

================================================================
==6158==ERROR: AddressSanitizer: heap-use-after-free on address 0x61800003eda0 at pc 0x55fbbb8f1299 bp 0x7ffc346f2020 sp 0x7ffc346f2010
READ of size 8 at 0x61800003eda0 thread T0
    #0 0x55fbbb8f1298 in std::_Deque_iterator<UI::BaseListselect::EntryRecord*, UI::BaseListselect::EntryRecord*&, UI::BaseListselect::EntryRecord**>::_Deque_iterator(std::_Deque_iterator<UI::BaseListselect::EntryRecord*, UI::BaseListselect::EntryRecord*&, UI::BaseListselect::EntryRecord**> const&) /usr/include/c++/7/bits/stl_deque.h:152
    #1 0x55fbbb8f1232 in std::deque<UI::BaseListselect::EntryRecord*, std::allocator<UI::BaseListselect::EntryRecord*> >::begin() /usr/include/c++/7/bits/stl_deque.h:1167
    #2 0x55fbbb8ea1a3 in UI::BaseListselect::clear() ../src/ui_basic/listselect.cc:95
    #3 0x55fbbb8cf6fc in UI::BaseDropdown::~BaseDropdown() ../src/ui_basic/dropdown.cc:151
    #4 0x55fbbb52cb26 in UI::Dropdown<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::~Dropdown() ../src/ui_basic/dropdown.h:224
    #5 0x55fbbc30e0ec in EconomyOptionsWindow::~EconomyOptionsWindow() ../src/wui/economy_options_window.cc:126
    #6 0x55fbbc30e17f in EconomyOptionsWindow::~EconomyOptionsWindow() ../src/wui/economy_options_window.cc:134
    #7 0x55fbbb910d1d in UI::Panel::free_children() ../src/ui_basic/panel.cc:128
    #8 0x55fbbb9108ce in UI::Panel::~Panel() ../src/ui_basic/panel.cc:100
    #9 0x55fbbba82826 in InteractiveBase::~InteractiveBase() ../src/wui/interactive_base.cc:189
    #10 0x55fbbbae54c1 in InteractiveGameBase::~InteractiveGameBase() ../src/wui/interactive_gamebase.h:58
    #11 0x55fbbbaea715 in InteractivePlayer::~InteractivePlayer() ../src/wui/interactive_player.h:38
    #12 0x55fbbbaea73d in InteractivePlayer::~InteractivePlayer() ../src/wui/interactive_player.h:38
    #13 0x55fbbb6a9884 in std::default_delete<InteractiveBase>::operator()(InteractiveBase*) const (economy-target-profiles/widelands+0x1150884)
    #14 0x55fbbb6a817e in std::unique_ptr<InteractiveBase, std::default_delete<InteractiveBase> >::reset(InteractiveBase*) /usr/include/c++/7/bits/unique_ptr.h:376
    #15 0x55fbbb69d8f8 in Widelands::EditorGameBase::set_ibase(InteractiveBase*) ../src/logic/editor_game_base.cc:222
    #16 0x55fbbb6b7242 in Widelands::Game::run(UI::ProgressWindow*, Widelands::Game::StartGameType, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ../src/logic/game.cc:576
    #17 0x55fbbb39b1a0 in WLApplication::new_game() ../src/wlapplication.cc:1350
    #18 0x55fbbb399280 in WLApplication::mainmenu_singleplayer() ../src/wlapplication.cc:1204
    #19 0x55fbbb3983cb in WLApplication::mainmenu() ../src/wlapplication.cc:1110
    #20 0x55fbbb38f3b1 in WLApplication::run() ../src/wlapplication.cc:466
    #21 0x55fbbb38b14e in main ../src/main.cc:44
    #22 0x7f3374bb0b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)
    #23 0x55fbbb38afc9 in _start (economy-target-profiles/widelands+0xe31fc9)