Code review comment for lp:~widelands-dev/widelands/dynamic_tribe_loading

Revision history for this message
SirVer (sirver) wrote :

I think this is a cool feature, thanks for working on this.

I am a bit unhappy about the postload() design approach, but that is not the fault of this branch. We are constructing partially initialized objects right and left and that gets pretty confusing - when is which data valid? I think it would be better to collecting all inter-object dependencies while loading the objects into a collection that is passed around to the loading functions. Later, they are all resolved at one point and missing objects can be reported then. What do you think? Do you want to try this in this branch or defer?

review: Needs Fixing

« Back to merge proposal