Code review comment for lp:~widelands-dev/widelands/critter_editor_categories

Revision history for this message
kaputtnik (franku) wrote :

> The different terrain window sizes were probably done on purpose as well to group the same types of > terrain as much as possible - I coded this a few months ago, so I don't remember 100% right now.

I guess one could not be sure that this ordering assumption is ever valid. E.g. when one arable terrain is added, the order of "arable terrains first" may result in an ugly ordering, or switching window sizes is much bad. So for the terrains menu it would maybe better to have equal values for 'items_per_row' for each tab (summer, wasteland, ...). For the immovables and critters i think the ordering is ok.

> I haven't looked at how the order of Editor elements might affect savegames - we should saveload a > map and check if it still looks the same just to be sure.

Loaded old maps and saveload a map with this branch, they still look the same.

« Back to merge proposal