Code review comment for lp:~widelands-dev/widelands/critter_editor_categories

Revision history for this message
toptopple (7010622-q-deactivatedaccount) wrote :

I am a bit sceptical about the amount of redundant text that appears in the selection windows of Immovables and Animals. You have also added the text to the Animals window which didn't show it before. The standard text showing everywhere is "Click to select an item. Use the Ctrl key to select multiple items." I wonder for what is it good?

1. "Click to select an item." is redundant, everyone using this tool can be expected to guess this.
2. "Use the Ctrl key to select multiple items." This is useful information, but is it enough and is it in the right place? Once you understood the message, this text still appears as graphic clutter during all your editor work (more or less) and consuming needed view space. Then, have you looked at the "Duck" window and how the text appears there? It's a monument of redundancy and it will not take long until people will start asking "Why?".

I further find two things:

A) Help texts of the mentioned type can be placed as a hover-text on a small Help button, like e.g showing "?", in the bottom right of each selection window. You can even put more information there, e.g. on what multiple selections can be used for. Then this type of text can disappear from the displays.
B) What could, additionally, indeed show in the bottom of the displays is an explanatory text for the chosen category (tab) if there is a special practical relevance to these items. E.g. the "Rocks" tab could say "Items here can be mined for the Stone and Marble resource.". Or. "Dead trees can never be removed." Etc.

Hope this can give some ideas which are useful.

review: Needs Fixing

« Back to merge proposal