Merge lp:~widelands-dev/widelands/copyright-file into lp:~widelands-dev/widelands/debian

[Hans Joachim Desserud]

Update the copyright file in debian packaging to document the various licenses origins of files used. Mainly to incorporate the new fonts we now bundle, but I also thought we should probably mention our third party libraries.

We have not yet documented all of these properly though, see copyright.todo for details on remaining work. There are some questions there where I'm not sure how to proceed. I'm also open for other feedback.

I think it is possible to add individual people as reviewers, so I'll add GunChleoc (since you added the fonts) and Martin Quinson since you're the Debian maintainer and probably know more about this than me. Being appointed as reviewers will presumably ping you so that you are aware of this merge proposal. Combined I believe we can answer the questions I have posted, and get the copyright file up to date. :)

[GunChleoc (gunchleoc)]

I used diff comments to add some more info.

[Hans Joachim Desserud (hjd)]

This is surprisingly hard.

I did have some progress when I discovered that I can open fonts in FontViewer on Ubuntu and it will be able to disply embedded information such as copyright information.

[SirVer (sirver)]

ping. hjd, what is the state of this branch?

[Hans Joachim Desserud (hjd)]

>ping. hjd, what is the state of this branch?

Hello hello. Not much has happened since the previous commit/comment.

Like I talked about in https://code.launchpad.net/~hjd/widelands/tests-poc/+merge/250533, the main intent with this branch was to get the packaging in a better shape to make it easier to create the official Debian packages once we release build19 (rc). It is my understanding that the Debian policies require packages to give full copyright statement on their content, so since it will need to be done anyways we might as well get it done early.

This work is not critical for Widelands itself since we don't really have such obligations (unless specific licenses state otherwise) but is in general nice to give credit to other people's work which we include. I'd say we are doing a good job of this though, at least with the fonts/licenses there.

As I mentioned, I believe this work will need to be done for the offical Debian packages, which is why I wanted to start it straight away, while the new fonts were still fresh. This is also why I added the Debian maintainer as a reviewer here, hoping to get some feedback and possibly guidance.

I am a bit stuck on the questions in the todo, and I don't really know how to proceed with this. I'll leave this open for a while longer, but if I don't hear anything, I'll likely close it as a draft/experiment. While I would like to see this done properly, I don't know whether the current state of the branch does more good than harm, and I don't think it is that critical for the Widelands project to have this file 100% completed.

[Martin Quinson (mquinson)]

I'm so deep under water wrt my daytime job that I am completely unable to help (or even properly read your emails) before the summer.

Sorry and good luck
Mt

----- Mail original -----
> >ping. hjd, what is the state of this branch?
>
> Hello hello. Not much has happened since the previous commit/comment.
>
> Like I talked about in
> https://code.launchpad.net/~hjd/widelands/tests-poc/+merge/250533, the main
> intent with this branch was to get the packaging in a better shape to make
> it easier to create the official Debian packages once we release build19
> (rc). It is my understanding that the Debian policies require packages to
> give full copyright statement on their content, so since it will need to be
> done anyways we might as well get it done early.
>
> This work is not critical for Widelands itself since we don't really have
> such obligations (unless specific licenses state otherwise) but is in
> general nice to give credit to other people's work which we include. I'd say
> we are doing a good job of this though, at least with the fonts/licenses
> there.
>
> As I mentioned, I believe this work will need to be done for the offical
> Debian packages, which is why I wanted to start it straight away, while the
> new fonts were still fresh. This is also why I added the Debian maintainer
> as a reviewer here, hoping to get some feedback and possibly guidance.
>
> I am a bit stuck on the questions in the todo, and I don't really know how to
> proceed with this. I'll leave this open for a while longer, but if I don't
> hear anything, I'll likely close it as a draft/experiment. While I would
> like to see this done properly, I don't know whether the current state of
> the branch does more good than harm, and I don't think it is that critical
> for the Widelands project to have this file 100% completed.
> --
> https://code.launchpad.net/~widelands-dev/widelands/copyright-file/+merge/245297
> You are requested to review the proposed merge of
> lp:~widelands-dev/widelands/copyright-file into
> lp:~widelands-dev/widelands/debian.
>

[Hans Joachim Desserud (hjd)]

No problem Martin, that's completely understandable. Thanks for letting us know. :)

In the meantime, I'll just put this branch on ice, and we'll get back to it when we have a better idea on how to proceed. I'll try to adjust the review status so that it doesn't show up in the list of active reviews.

=== modified file 'debian/copyright'
--- debian/copyright	2014-12-13 12:37:38 +0000
+++ debian/copyright	2014-12-27 11:47:34 +0000
@@ -22,6 +22,103 @@
  On Debian systems, the complete text of the GNU General Public
  License version 2 can be found in "/usr/share/common-licenses/GPL-2".
   
+Files: src/third_party/eris/*
+Copyright: 2013 Florian Nücke, 1994–2013 Lua.org, PUC-Rio.
+License:
+Eris
+Copyright (c) 2013 Florian Nücke.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+
+-----------------------------------------------------------------------------
+
+Lua 5.2.2 from http://www.lua.org/ with patches http://www.lua.org/bugs.html
+slightly modified to access internal library functions for persistence.
+
+Copyright © 1994–2013 Lua.org, PUC-Rio.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+
+Files: i18n/fonts/Culmus/*
+Copyright: 2010 by Yoram Gnat ([e-mail]).
+License: This package is distributed under the terms of GNU General Public License
+version 2 (see file GNU-GPL).
+---------------------------------------------------------------------
+
+"Taamey Frank CLM" fonts are copyright (C) 2010 by Yoram Gnat
+([e-mail]). All rights reserved.
+
+As a special exception, if you create a document which uses 
+this font, and embed this font or unaltered portions of this
+font into the document, this font does not by itself cause
+the resulting document to be covered by the 
+GNU General Public License. This exception does not however
+invalidate any other reasons why the document might be covered
+by the GNU General Public License. If you modify this font,
+you may extend this exception to your version of the font,
+but you are not obligated to do so. If you do not wish to do so,
+delete this exception statement from your version. 
+
+Files: i18n/fonts/Nakula/*
+Copyright: Nakula Devanagari font © 2006 University of Cambridge. Designed and developed by  IMRC, India. Latin and Cyrillic glyphs from the font Nimbus Roman No9 L Regular, © 1999 (URW)++ Design & Development; Cyrillic glyphs by Valek Filippov © 2001-2002.
+License:
+These fonts are free software; you can redistribute them and/or modify them under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.
+
+These fonts are distributed in the hope that they will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+
+Files: i18n/fonts/Sinhala/*
+Copyright: 2004,2008 Anuradha Ratnaweera and Harshani Devadithya, 2006 Harshula Jayasuriya, 1994, The Wellcome Trust, London
+License:
+  LKLUG font is free software; you can redistribute it and/or modify
+  it under the terms of the GNU General Public License, version 2, as
+  published by the Free Software Foundation.
+
+  This program is distributed in the hope that it will be useful, but
+  WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+  General Public License, version 2, for more details.
+
+  The Debian packaging is (C) 2004,2008, Anuradha Ratnaweera, and is
+  licensed under the GNU General Public License, version 2.
+
+  You should have received a copy of the GNU General Public License,
+  version 2, in the file `COPYING', or on Debian based systems in the
+  file `/usr/share/common-licenses/GPL-2'; if not, write to the Free
+  Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+  MA 02110-1301 USA.
+
 Files: i18n/fonts/Widelands/Widelands.ttf
 Copyright: 2006-2010, Peter Schwanemann (Peter (AT) drehatlas (DOT) de)
 License: SIL Open Font License, Version 1.1 (http://scripts.sil.org/OFL)
 
=== added file 'debian/copyright.todo'
--- debian/copyright.todo	1970-01-01 00:00:00 +0000
+++ debian/copyright.todo	2014-12-27 11:47:34 +0000
@@ -0,0 +1,34 @@
+Documents known missing entries in the copyright file
+
+src/thirdparty/minizip/*
+We've shipped this for a while, only the fonts below are new.
+According to the readme it originates from zlib's minizip example, though has
+been modified in Widelands, so we may want to document this, including our
+changes. What's best practice here, mark it based on the original license and
+then mention any modifications done by the Widelands team?
+
+i18n/fonts/DejaVu/*
+Our bundled version mentions something about glyphs which I can't find at 
+https://tracker.debian.org/pkg/fonts-dejavu. I assumed we could follow the
+example from that package on how to document these fonts, but I don't know if
+the glyphs doesn't need a specific mentioning or whether the Debian package has
+stripped them out. Anyone know?
+
+i18n/fonts/FaKacstBook/*
+Presumably GPLed, but doesn't detail which version nor the copyright holder.
+The Launchpad site says GPL v2, but the tar.gz doesn't include a license file.
+
+i18n/fonts/MicroHei/*
+"This font is licensed under Apache2.0 or GPLv3
+               with font embedding exceptions (see Appendix B)."
+Don't know how we deal with dual-licensing in this context. Do we pick one, or
+should both be listed?
+
+i18n/fonts/*mmrCensus*
+Open Font License. Again we may need some name(s).
+>I found their project homepage: https://code.google.com/p/myanmar3source/
+Now I'm confused. The project page mentions the following:
+Code license
+GNU Lesser GPL
+Content license
+Creative Commons 3.0 BY