Code review comment for lp:~widelands-dev/widelands/casern_workersqueue

Revision history for this message
Notabilis (notabilis27) wrote :

GunChleoc, can you take a look at you "versioning" changes in map_buildingdata_packet.cc, please? The current version does not pass the regression tests.

The problem is the line:

  if (packet_version > 5) {

Since kCurrentPacketVersionProductionsite is still set to 5, the code differs on read and write. I would guess that kCurrentPacketVersionProductionsite should have been increased to 6 but I am not sure enough about it to dare to fix it myself. Can you fix it or tell me to do it?

« Back to merge proposal