Code review comment for lp:~widelands-dev/widelands/buildicon_playercolors

Revision history for this message
Jens Beyer (qcumber-some) wrote :

Thanks for the review and the suggestion.

Now that I have something working, it is easier for me to discuss it, so please be patient with me ;-)
I did not have a look into your branch yet, but from what I think I understand, you want to use a "representative image" of the animation, which is one, possibly selected, frame of the animation, and use it for the menus instead of menu.png/menu_pc.png.

I agree this would be awesome, and I think I could implement it (technologically).
And I will certainly go for this as a test (one can only learn from it).

But the animations are all at a very different size ranging from higher-than-wide to wider-than-high, while the menu items are at a fixed size. I can not really imagine having the build icons in the build menu at different sizes looking nicely, and I certainly don't want to force-resize them to equal-ratio 30x30px (as an example). What would be the correct approach to that?

« Back to merge proposal