Merge lp:~widelands-dev/widelands/bug_1760581-fix-UnicodeString into lp:widelands

Proposed by GunChleoc
Status: Merged
Merged at revision: 8641
Proposed branch: lp:~widelands-dev/widelands/bug_1760581-fix-UnicodeString
Merge into: lp:widelands
Diff against target: 12 lines (+1/-1)
1 file modified
src/graphic/text/bidi.h (+1/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug_1760581-fix-UnicodeString
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+342544@code.launchpad.net

Commit message

Fixed compile error in bidi.h and icu 61

Description of the change

Already reviewed and tested

@bunnybot merge

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) :
review: Approve
Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 3335. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/361556708.
Appveyor build 3141. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1760581_fix_UnicodeString-3141.

Revision history for this message
kaputtnik (franku) wrote :

All fine.

@bunnybot merge

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/graphic/text/bidi.h'
2--- src/graphic/text/bidi.h 2017-01-25 18:55:59 +0000
3+++ src/graphic/text/bidi.h 2018-04-03 08:47:09 +0000
4@@ -40,7 +40,7 @@
5 // True if a string contains a character from the script's code blocks
6 bool has_script_character(const char* input, UI::FontSets::Selector script);
7 UI::FontSet const* find_fontset(const char* word, const UI::FontSets& fontsets);
8-std::string icustring2string(const UnicodeString& convertme);
9+std::string icustring2string(const icu::UnicodeString& convertme);
10 std::string icuchar2string(const UChar& convertme);
11 bool cannot_start_line(const UChar& c);
12 bool cannot_end_line(const UChar& c);

Subscribers

People subscribed via source and target branches

to status/vote changes: