Merge lp:~widelands-dev/widelands/bug_1566720_set_origin into lp:widelands
Proposed by
kaputtnik
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 7948 | ||||
Proposed branch: | lp:~widelands-dev/widelands/bug_1566720_set_origin | ||||
Merge into: | lp:widelands | ||||
Diff against target: |
14 lines (+2/-2) 1 file modified
src/editor/tools/set_origin_tool.cc (+2/-2) |
||||
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug_1566720_set_origin | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
GunChleoc | Approve | ||
Review via email: mp+291207@code.launchpad.net |
Commit message
Fix miscalculation of map->get_width() and map->get_height() regarding coordinates.
Description of the change
This fixes bug 1566720.
The culprit was that map->get_width() and map->get_height() returns f.e. 64 with a map of 64x64. But internally calculations are made with range 0 to 63.
I have checked the other usages of map->get_width() and map->get_height() and it seems the other usages are fine.
Because i am not very familiar with the code someone else should may check the other usages of map->get_width() and map->get_height() to prevent some more bugs with this circumstance.
To post a comment you must log in.
Continuous integration builds have changed state:
Travis build 978. State: passed. Details: https:/ /travis- ci.org/ widelands/ widelands/ builds/ 121359254. /ci.appveyor. com/project/ widelands- dev/widelands/ build/_ widelands_ dev_widelands_ bug_1566720_ set_origin- 811.
Appveyor build 811. State: success. Details: https:/