Merge lp:~widelands-dev/widelands/bug1201398 into lp:widelands

Proposed by cghislai
Status: Merged
Merged at revision: 6641
Proposed branch: lp:~widelands-dev/widelands/bug1201398
Merge into: lp:widelands
Diff against target: 0 lines
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug1201398
Reviewer Review Type Date Requested Status
SirVer Approve
Review via email: mp+174809@code.launchpad.net

Description of the change

This corrects a few things with my previous save dialog changes.
Thanks hjd for pointing it out, there was a few other issues.

A new field in game has been created to remember players amount
Game preload data version has been increased to make use of player amounts
Save game shows current game info on first save and remembers save file
Save/Load/Replay have been updated to correctly show the informations

To post a comment you must log in.
Revision history for this message
SirVer (sirver) wrote :

Couple of small comments in the code. search for NOCOM as before.

review: Needs Fixing
Revision history for this message
cghislai (charlyghislain) wrote :

I tested it and it works as expected.

For older game version, were the number of player is not preloaded, "Players: Unknown" will be shown in the load dialog. Once the game is loaded, the correct number of players will be computed.

For older game version, the win condition seemed to be stored as the filename. Scripts are now parsed in an attempt to get a localized string, otherwise the filename will be displayed.

Revision history for this message
SirVer (sirver) wrote :

lgtm. I removed one unneeded boost header and merged to trunk.

review: Approve

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: