Code review comment for lp:~widelands-dev/widelands/bug-768826

Revision history for this message
GunChleoc (gunchleoc) wrote :

LGTM, except for a couple more nits. One functionality change:

- In the editor, remove the blank space between ( and the first coordinate

And two code style nits:

- add operator padding to (is_game)?25:5 (codecheck doesn't catch this case, but it should look like this: (is_game) ? 25 : 5)

- Properly align the closing parenthesis for dst.blit(. It should either be where it was, or at the end of the last parameter - I think the last option is preferred.

« Back to merge proposal