Merge lp:~widelands-dev/widelands/bug-1830776-password-field-captures-input into lp:widelands

Proposed by Toni Förster
Status: Merged
Merged at revision: 9132
Proposed branch: lp:~widelands-dev/widelands/bug-1830776-password-field-captures-input
Merge into: lp:widelands
Diff against target: 19 lines (+1/-1)
1 file modified
src/wui/login_box.cc (+1/-1)
To merge this branch: bzr merge lp:~widelands-dev/widelands/bug-1830776-password-field-captures-input
Reviewer Review Type Date Requested Status
GunChleoc Approve
Review via email: mp+368063@code.launchpad.net

Commit message

Don't force focus on password field

To post a comment you must log in.
Revision history for this message
GunChleoc (gunchleoc) wrote :

Yep, that fixed it :)

@bunnybot emrge

review: Approve
Revision history for this message
Toni Förster (stonerl) wrote :

@bunnybot merge :)

Revision history for this message
bunnybot (widelandsofficial) wrote :

Continuous integration builds have changed state:

Travis build 5082. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/538820816.
Appveyor build 4862. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1830776_password_field_captures_input-4862.

Revision history for this message
bunnybot (widelandsofficial) wrote :

Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways.

Travis build 5082. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/538820816.

Revision history for this message
Toni Förster (stonerl) wrote :

inputqueues again.

@bunnybot merge force

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/wui/login_box.cc'
2--- src/wui/login_box.cc 2019-05-26 01:59:32 +0000
3+++ src/wui/login_box.cc 2019-05-29 12:51:06 +0000
4@@ -144,6 +144,7 @@
5 } else {
6 ta_password->set_style(g_gr->styles().font_style(UI::FontStyle::kLabel));
7 eb_password->set_can_focus(true);
8+ eb_password->focus();
9 }
10 }
11
12@@ -168,7 +169,6 @@
13 if (eb_password->text().empty() && cb_register->get_state()) {
14 eb_password->set_tooltip(_("Please enter your password!"));
15 loginbtn->set_enabled(false);
16- eb_password->focus();
17 }
18
19 Section& s = g_options.pull_section("global");

Subscribers

People subscribed via source and target branches

to status/vote changes: