Merge lp:~widelands-dev/widelands/bug-1815283-nil-value-territorial into lp:widelands
Proposed by
Toni Förster
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 8982 | ||||
Proposed branch: | lp:~widelands-dev/widelands/bug-1815283-nil-value-territorial | ||||
Merge into: | lp:widelands | ||||
Diff against target: |
41 lines (+4/-4) 2 files modified
data/scripting/win_conditions/territorial_functions.lua (+2/-2) data/scripting/win_conditions/win_condition_functions.lua (+2/-2) |
||||
To merge this branch: | bzr merge lp:~widelands-dev/widelands/bug-1815283-nil-value-territorial | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
GunChleoc | Approve | ||
Review via email: mp+363079@code.launchpad.net |
Commit message
add player name to rank_players()
To post a comment you must log in.
I looked also into this issue and stumbled over player.number and the description of players: https:/ /wl.widelands. org/documentati on/autogen_ wl_bases/ #wl.bases. EditorGameBase. players
So, assuming the second slot of a three players map is deactivated, the result will be:
for idx, player in ipairs( wl.Game( ).players) do
print(idx, player.name, player.number)
end
Output:
1 Player 1 1
2 Player 3 3
So i am not sure if we should get rid of player.number at all? Don't know if it is feasible.